After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710331 - Fix posix shell syntax error
Fix posix shell syntax error
Status: RESOLVED FIXED
Product: yelp-tools
Classification: Core
Component: yelp-check
3.10.x
Other Linux
: Normal normal
: ---
Assigned To: Yelp maintainers
Yelp maintainers
Depends on:
Blocks:
 
 
Reported: 2013-10-16 22:24 UTC by Michael Biebl
Modified: 2013-10-27 15:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] Fix posix shell syntax error (686 bytes, patch)
2013-10-16 22:24 UTC, Michael Biebl 		committed Details | Review

Description Michael Biebl 2013-10-16 22:24:14 UTC 
Created attachment 257462 [details] [review]
[PATCH] Fix posix shell syntax error

Commit a43c830b303c117214201d4af37e67baa6e455e5 introduced the following error when running the script with dash, a posix compliant shell.
sh -n tools/yelp-check
tools/yelp-check: 696: tools/yelp-check: Syntax error: Missing '))'


Afaics the code tries to run a subshell and pipe that output through xsltproc.
So having a white space between the two (( should fix this.

Attached patch does that.
Comment 1 Shaun McCance 2013-10-27 15:39:34 UTC 
Thanks for the fix.