After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710324 - encodebin: Implement subtitles support
encodebin: Implement subtitles support
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 710322 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-10-16 20:45 UTC by Thibault Saunier
Modified: 2018-11-03 11:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
encodebin: Do not systematically fail when no encoder is found (3.78 KB, patch)
2013-10-16 20:45 UTC, Thibault Saunier
accepted-commit_now Details | Review
encodebin: Implement subtitles handling (10.41 KB, patch)
2013-10-16 20:45 UTC, Thibault Saunier
none Details | Review
encodebin: Implement subtitles support (10.41 KB, patch)
2013-10-16 22:05 UTC, Thibault Saunier
needs-work Details | Review
encodebin: Do not systematically fail when no encoder is found (3.78 KB, patch)
2014-05-26 17:31 UTC, Thibault Saunier
accepted-commit_now Details | Review
encodebin: Implement subtitles support (10.36 KB, patch)
2014-05-26 17:31 UTC, Thibault Saunier
reviewed Details | Review

Description Thibault Saunier 2013-10-16 20:45:35 UTC
Currently encodebin does not support encodebin, we should impleement its support.

I attach here 2 patches aiming at implementing it.
Comment 1 Thibault Saunier 2013-10-16 20:45:37 UTC
Created attachment 257452 [details] [review]
encodebin: Do not systematically fail when no encoder is found

In the case we can not find any encoder for a particular stream,
and if the user is requesting a pad that is already compatible with
the profile, we should just go without encoder, even if the caps
are not raw caps.
Comment 2 Thibault Saunier 2013-10-16 20:45:43 UTC
Created attachment 257453 [details] [review]
encodebin: Implement subtitles handling
Comment 3 Tim-Philipp Müller 2013-10-16 22:01:45 UTC
*** Bug 710322 has been marked as a duplicate of this bug. ***
Comment 4 Thibault Saunier 2013-10-16 22:05:20 UTC
Created attachment 257460 [details] [review]
encodebin: Implement subtitles support
Comment 5 Christian Fredrik Kalager Schaller 2014-02-04 10:26:20 UTC
Anyone looking at reviewing this?
Comment 6 Sebastian Dröge (slomo) 2014-04-04 09:20:52 UTC
Review of attachment 257460 [details] [review]:

Looks good in general, a test would be good to have and minor nitpick:

::: gst-libs/gst/pbutils/encoding-profile.c
@@ +668,3 @@
+
+  guint pass;
+  gboolean variableframerate;

Why pass and variableframerate for subtitles? They are always VFR and I'm not aware of a single multipass encoder for subtitles ;)
Comment 7 Sebastian Dröge (slomo) 2014-05-03 07:57:36 UTC
Thibault?
Comment 8 Thibault Saunier 2014-05-26 17:31:08 UTC
Created attachment 277233 [details] [review]
encodebin: Do not systematically fail when no encoder is found

In the case we can not find any encoder for a particular stream,
and if the user is requesting a pad that is already compatible with
the profile, we should just go without encoder, even if the caps
are not raw caps.
Comment 9 Thibault Saunier 2014-05-26 17:31:15 UTC
Created attachment 277234 [details] [review]
encodebin: Implement subtitles support
Comment 10 Thibault Saunier 2014-05-26 17:33:33 UTC
I tested with gst-validate and have test ready for it but I have not made any unit tests as I was inspirationless about how they should look like.
Comment 11 Mathieu Duponchelle 2017-10-16 12:27:47 UTC
Review of attachment 277233 [details] [review]:

Makes sense to me
Comment 12 Mathieu Duponchelle 2017-10-16 12:33:24 UTC
Review of attachment 277234 [details] [review]:

You'll also want to update win32/common/libgstpbutils.def

::: gst-libs/gst/pbutils/encoding-profile.c
@@ +915,3 @@
+ * Creates a new #GstEncodingSubtitleProfile
+ *
+ * All provided allocatable arguments will be internally copied, so can be

We don't usually say this, as annotations are exposed in the documentation

::: gst-libs/gst/pbutils/encoding-profile.h
@@ +98,3 @@
 
+/**
+ * GstEncodingSubtitleProfile:

Why call it "subtitle" profile and not "text" ? "text" seems a bit more agnostic to me :)
Comment 13 Tim-Philipp Müller 2018-01-27 11:26:05 UTC
> +/**
> + * GstEncodingSubtitleProfile:
> 
> Why call it "subtitle" profile and not "text" ? "text" seems a bit more
> agnostic to me :)

Are you saying that "Text" would be better because it's semantically neutral (could be text that's not subtitles, but metadata)?

I think subtitles is a better fit for most practical use cases. And subtitles might also come in a form that's not text, but bitmaps (dvd, dvb, bluray-style subs).
Comment 14 Edward Hervey 2018-05-22 10:00:10 UTC
And it could also be Closed Caption :) Which is neither text, nor subpictures
Comment 15 GStreamer system administrator 2018-11-03 11:26:20 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/92.