After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710300 - double notification in system section
double notification in system section
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: properties
unspecified
Other Linux
: Normal normal
: 3.22
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-10-16 16:20 UTC by Matthias Clasen
Modified: 2016-03-31 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot of infobar w/ restart button (273.68 KB, image/png)
2014-02-11 12:20 UTC, Zeeshan Ali
Details

Description Matthias Clasen 2013-10-16 16:20:38 UTC
(from Montreal summit section)

When making changes to the sliders, we got both an infobar and an in-app notification. We should only have the infobar, and move the button there.
Comment 1 Jakub Steiner 2014-02-11 12:19:40 UTC
I don't think we have a guideline about infobars, but I feel like they are describing the specific view and can't be dismissed. This totally sounds like a notification to be shown when you alter a value that requires a reboot (perhaps not showing it again if you dismissed with a close button and haven't changed the view).
Comment 2 Zeeshan Ali 2014-02-11 12:20:47 UTC
Created attachment 268785 [details]
Screenshot of infobar w/ restart button

So here is how it looks like: i-e ugly. I showed it to jimmac and he wasn't sure we want infobar here at all.

How about we instead just show the notification after user exits the properties view (i-e after making all the changes)?
Comment 3 Jakub Steiner 2014-02-11 12:37:51 UTC
The notification on exit-view works for me.
Comment 4 Zeeshan Ali 2014-02-11 12:45:34 UTC
(In reply to comment #3)
> The notification on exit-view works for me.

OK cool, lets go with that for now.
Comment 5 Marc-Andre Lureau 2014-02-11 13:00:15 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > The notification on exit-view works for me.
> 
> OK cool, lets go with that for now.


So if I go in properties, how do I know if those value are actual values?
Comment 6 Zeeshan Ali 2014-02-11 13:07:55 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > The notification on exit-view works for me.
> > 
> > OK cool, lets go with that for now.
> 
> 
> So if I go in properties, how do I know if those value are actual values?

They are actual values, just not in effect yet and we do notify user of that and give them a chance to easily put them in immediate effect.
Comment 7 Zeeshan Ali 2014-02-11 13:43:08 UTC
Pushed some patches to git master that:

* remove the infobar
* presents notification only after user is done with making all changes.
* changes the language of notification slightly to not present 'Yes' button, as per HIG.