GNOME Bugzilla – Bug 710272
Test-suite fails with libsoup 2.44.1
Last modified: 2013-11-01 22:38:32 UTC
Grilo-plugins test suite fails when running against libsoup 2.44.1: [ 125s] ERROR:test_tmdb_fast_resolution.c:73:test_fast_resolution: assertion failed (error == NULL): Could not find mock content Key file does not have group 'http://api.themoviedb.org/3/configuration?api_key=TMDB_TEST_API_KEY' (grilo.error.general, 5) [ 125s] FAIL From a conversation with Dan, maintainer of libsoup: 15:32 < danw> DimStar: ok, so the failure is caused by https://bugzilla.gnome.org/show_bug.cgi?id=708621. the fix there is correct; if it breaks grilo-plugins, then grilo-plugins is doing something wrong, and it just got lucky before. 15:32 < Services> Bug 708621: critical, Normal, ---, libsoup-maint, RESOLVED FIXED, append_form_encoded encode all non alphanum including valid dot, dash, unerscore and tilde 15:32 < danw> (in particular, it now ends up looking for "http://api.themoviedb.org/3/configuration?api_key=TMDB_TEST_API_KEY" rather than "http://api.themoviedb.org/3/configuration?api%5Fkey=TMDB%5FTEST%5FAPI%5FKEY" in the keyfile) 15:36 < DimStar> danw: Thanks... 15:37 < DimStar> danw: frankly, it looks more correct to have it decoded in the keyfile anyway :) 15:38 < danw> DimStar: yeah... but anyway, if grilo needs a very particular set of characters to be encoded in order for things to work right, then it should call soup_uri_encode() and pass those characters explicitly 15:39 < DimStar> danw: will try to pass this on to the grilo team... Thanks for looking into it!
Created attachment 258485 [details] [review] tests: Do not escape URI in TMDb tests
commit 4f84d1831722c731d5a7a351d26a69fe355be210 Author: Juan A. Suarez Romero <jasuarez@igalia.com> Date: Tue Oct 29 20:34:59 2013 +0000 tests: Do not escape URI in TMDb tests https://bugzilla.gnome.org/show_bug.cgi?id=710272 tests/tmdb/data/fast-by-id.ini | 4 ++-- tests/tmdb/data/no-details.ini | 4 ++-- tests/tmdb/data/sherlock.ini | 14 +++++++------- 3 files changed, 11 insertions(+), 11 deletions(-)