GNOME Bugzilla – Bug 710252
[facebook account] entered username can not be selected properly
Last modified: 2014-06-04 09:49:42 UTC
In "add Facebook chat account" widget, the username entered can not be properly selected. I mean it is white highlighted over white text. The cause is that Facebook chat account is handled differently than other chat protocol accounts in order to implicitly add "@chat.facebook.com" suffix. The suffix mechanism seems to bring this display issue.
Created attachment 265534 [details] [review] account-widget: use the "error" CSS class on wrong entries That's the proper way to do as GTK+ defines this class for exactly this purpose. Our current code was pretty hacky anyway. This also has the nice side effect of fixing a bug making the text unreadable when selecting it from the entry.
You can use GTK_STYLE_CLASS_ERROR. That seems to be the only user of tpaw_make_color_whiter() so it can be removed as well.
(In reply to comment #2) > You can use GTK_STYLE_CLASS_ERROR. Oh yeah I forgot about those; thanks. > That seems to be the only user of > tpaw_make_color_whiter() so it can be removed as well. Indeed, it doesn't seem to be unused neither by Empathy or GOA.
Created attachment 265673 [details] [review] account-widget: use the "error" CSS class on wrong entries That's the proper way to do as GTK+ defines this class for exactly this purpose. Our current code was pretty hacky anyway. This also has the nice side effect of fixing a bug making the text unreadable when selecting it from the entry.
Created attachment 265674 [details] [review] remove tpaw_make_color_whiter() It's not used any more.
+1
Merged to master. Attachment 265673 [details] pushed as 6cf47a8 - account-widget: use the "error" CSS class on wrong entries Attachment 265674 [details] pushed as 0c066f5 - remove tpaw_make_color_whiter()
Review of attachment 265673 [details] [review]: Wanted to point out that this patch triggers bug 724084