GNOME Bugzilla – Bug 710202
gst-rtsp-server: Improve unit tests (and fix bugs) for media factory permissions
Last modified: 2014-02-25 22:28:01 UTC
Created attachment 257372 [details] [review] Proposed patch for checking return values. And a trivial patch for verifying the return value of gst_rtsp_url_parse() in all tests. Enjoy!
Created attachment 257373 [details] [review] Proposed patch for testing mediafactory permissions
Created attachment 257712 [details] [review] Proposed patch for checking return values.
Created attachment 257713 [details] [review] Proposed patch for fixing bugs discovered when writing new unit tests. I found a few bugs while writing unit tests, let's squash them before adding the failing tests to keep gst-rtsp-server building for every commit.
Created attachment 257714 [details] [review] Proposed patch for adding new unit tests for RTSP permissions. Keeping the permissions unit tests separate keeps mediafactory tests dedicated to mediafactory. This is a better approach than I used previously.
Created attachment 257715 [details] [review] Proposed patch for testing mediafactory permissions. Revised patch that removes the permissions-specific unit tests, and retains the mediafactory related permissions tests.
Created attachment 257723 [details] [review] Proposed patch for adding new unit tests for RTSP permissions. D'oh. Don't leave unnecessary whitespace in there....
Created attachment 257724 [details] [review] Proposed patch for adding new unit tests for RTSP permissions. Double D'oh! Yes, do update with less whitespace damage, but then upload the _new_ patch, not the same old patch. :-/
commit a2eb48a27c4a68e1cbadf5a57055ac15046014c3 Author: Sebastian Rasmussen <sebras@hotmail.com> Date: Sat Oct 19 17:36:05 2013 +0200 tests: Add unit tests for permissions Fixes https://bugzilla.gnome.org/show_bug.cgi?id=710202 commit c0828a5d53648d6140fc8c37c52a92d60e9137f5 Author: Sebastian Rasmussen <sebras@hotmail.com> Date: Tue Oct 15 18:50:47 2013 +0200 tests: Test mediafactory permissions See https://bugzilla.gnome.org/show_bug.cgi?id=710202 commit 4036f210af2ae6081b5c79971a9068ab43421b7a Author: Sebastian Rasmussen <sebras@hotmail.com> Date: Sat Oct 19 17:39:35 2013 +0200 permissions: Fix refcounting when adding/removing roles Previously a role that was removed was unreffed twice, and when replacing an existing role the replaced role was freed while still being referenced. Both bugs are now fixed. See https://bugzilla.gnome.org/show_bug.cgi?id=710202 commit eee8b0db8835716e81e9c42c1f9ee58dbb04e2f1 Author: Sebastian Rasmussen <sebras@hotmail.com> Date: Tue Oct 15 18:01:38 2013 +0200 tests: Check gst_rtsp_url_parse return value See https://bugzilla.gnome.org/show_bug.cgi?id=710202