GNOME Bugzilla – Bug 710172
ges-formatter.h: 'class' usage as function argument name breaks build with c++ compilers
Last modified: 2013-10-15 09:54:50 UTC
ges\ges-formatter.h(138): error C2332: 'class' : missing tag name ges\ges-formatter.h(138): error C2011: '<unnamed-tag>' : 'enum' type redefinition ges\ges-formatter.h(138): error C2144: syntax error : '<unnamed-tag>' should be preceded by ')' ges\ges-formatter.h(138): error C2144: syntax error : '<unnamed-tag>' should be preceded by ';' ges\ges-formatter.h(138): error C2143: syntax error : missing ';' before ',' ges\ges-formatter.h(138): error C2059: syntax error : ',' ges\ges-formatter.h(144): error C2059: syntax error : ')' The above sytax error problem is for the below method declaration. void ges_formatter_class_register_metas (GESFormatterClass * class, const gchar *name, const gchar *description, const gchar *extension, const gchar *mimetype, gdouble version, GstRank rank);
Created attachment 257332 [details] [review] Fix for syntax errors modified the "class" parameter for 3 methods in 3 header files
Pushed, thanks: commit 71a6d75d757132028d13a6ed3d8dbfe77ed6b635 Author: Kishore Arepalli <kishore.arepalli@gmail.com> Date: Tue Oct 15 10:57:31 2013 +0200 ges-formatter: don't use 'class' as function argument name in headers It's a keyword in C++ and C++ compilers won't like it. https://bugzilla.gnome.org/show_bug.cgi?id=710172
Comment on attachment 257332 [details] [review] Fix for syntax errors Pushed with minor modifications (use 'klass' instead of '_class', which is the common idiom).