GNOME Bugzilla – Bug 710125
Basic visual fixes
Last modified: 2018-05-22 12:27:42 UTC
I'm no graphic artist, and Iagno really needs some custom artwork. That said, there are some basic things we can do to make the game look better: * Replace the dashed board lines with straight lines. * Include a line around the edge of the board. * Put some padding around the board. * Make the board green and the counters a simple black and white. https://raw.github.com/gnome-design-team/gnome-mockups/master/games/iagno/iagno.png
Thanks: those are all quite simple and I think they'll make a big difference. I also want to note the presence of the arrow next to the player to move; don't want to forget that. I'm a bit confused by the green color, though. At least that shade doesn't seem very appealing to me.
The green color is the traditional color used for the Reversi/Othello [1] board game (that iagno is a variant of according to the gnome wiki [2]) 1. http://en.wikipedia.org/wiki/Reversi 2. https://wiki.gnome.org/GnomeGames/
Here is what others use: https://www.google.com/search?q=othello&safe=off&client=firefox-a&hs=Hlm&rls=org.mozilla:en-US:official&source=lnms&tbm=isch&sa=X&ei=41RdUrqDN-Lv0gWV44HIBQ&ved=0CAkQ_AUoAQ&biw=1920&bih=946&dpr=1#q=othello+game&rls=org.mozilla:en-US%3Aofficial&safe=off&tbm=isch&imgdii=_
possibly #2e3436 could work too.
Created attachment 257352 [details] or like this thicker lines ala Othello and color is really close to the one I had as a kid :)
That shade looks good to me.
Created attachment 257386 [details] [review] Have a play around implementing Allan's design Main issues with the patch are: - Grid requests to be square but is assigned more width than height; this causes the offset to the left. - Alignment of widgets to the right of the grid
Created attachment 257388 [details] Screenshot of new design implementation
Do we want to put Undo in the window, or leave it in the app menu?
Review of attachment 257386 [details] [review]: This already looks loads better than the original... pushed to wip/redesign. TODO: Need a replacement for the infobar messages; passes are confusing without it (nifty scoreboard arrow or no), and we probably want to show when the game is over (besides just the flippy animation). I'm not sure the infobar wasn't the best way to handle that.
I've updated the mockups a bit (incorporating Andreas's changes): https://raw.github.com/gnome-design-team/gnome-mockups/master/games/iagno/iagno.png Changes include: * 2px wide stroke for the grid * Different background colour for the board * Added a bit of texture to the board background * Used some gradients and shadow on the counters
The only issue I see with the mockups is that it's missing an Undo button. I guess Scores can also go into the sidebar.
(In reply to comment #11) > * 2px wide stroke for the grid > * Different background colour for the board > * Added a bit of texture to the board background > * Used some gradients and shadow on the counters Our first 3.15 release is going to look very close to your mockup, thanks to Iulian Radu's work in bug #664983, but I'm leaving this bug open because these details aren't there: the stroke looked bad for some reason when it was changed to 2px, there's no texture on the board background, and we're still using our original counters. Our Start Over button is also bigger than yours, but we've sort of standardized on this button size so we'll probably leave that as-is unless you object. I think we're leaning towards using a new game screen instead of placing options in the sidebar, though.
Created attachment 286231 [details] screenshot of current implementation (thanks to Robert and Iulian)
Created attachment 286237 [details] [review] Set grid width stroke to 2px and apply texture to background.
Review of attachment 286237 [details] [review]: Hm, something's wrong with the background: I don't see any green at all unless I open the image in Firefox. Sometimes Inkscape and Firefox display SVGs differently than librsvg, unfortunately....
Created attachment 286241 [details] screenshot
Also, it'd be good to do this in two separate patches: one to change the stroke width, and one to change the backgrounds. They're really unrelated issues.
Created attachment 286243 [details] [review] Set grid width stroke to 2px. I can't figure out what's wrong with the background. Now I can't even see it green on Allan's mockup even after downloading the svg again. I'll leave it to the design team unless I figure it out in the meanwhile.
Comment on attachment 286243 [details] [review] Set grid width stroke to 2px. Thanks!
Created attachment 286284 [details] [review] Rework game-view.vala. Here is a patch I wanted to do for some times, and that is quite helped with tests I did on Taquin, that has similar parts of code. It does more than one thing, but it’s not easy to make them independent. It notably corrects the drawing of the lines (including a new GRID_BORDER parameter set to 3), but is mainly code corrections.
Review of attachment 286284 [details] [review]: Yeah, this looks better, thanks! ::: src/game-view.vala @@ +22,3 @@ + private int y_offset { get { return (get_allocated_height () - board_size) / 2; }} + + private void calculate () Functions go beneath the constructor. In this case, directly beneath the constructor, above draw where it's used, would be perfect. @@ +290,3 @@ public override bool button_press_event (Gdk.EventButton event) { + if (event.button == 1 || event.button == 3) Gross, do we really not have enums for these? I guess 3 is a right click. Can you split this change to a different patch, just so that it's easier to find in the commit history?
Remaining tasks: (In reply to comment #11) > * Added a bit of texture to the board background > * Used some gradients and shadow on the counters
Created attachment 286299 [details] [review] Rework game-view.vala. (In reply to comment #22) > Functions go beneath the constructor. In this case, directly beneath the > constructor, above draw where it's used, would be perfect. Like this? (In reply to comment #23) > Remaining tasks: > > (In reply to comment #11) > > * Added a bit of texture to the board background > > * Used some gradients and shadow on the counters If we want a texture, it should be done in a *separate* file than as background of the one with the tiles’ theme. It’s impossible with the actual way to have a correct function that “changes the background” for highlighting (hints, mouse hover, keyboard moves, etc.).
Comment on attachment 286299 [details] [review] Rework game-view.vala. M-hmm. Attachment 286299 [details] pushed as 27ab95f - Rework game-view.vala.
Created attachment 286507 [details] [review] Better drawing function. There’s more than one bug in my previous patch, that are not visible with the theme set in it, but that reveals themselves when you change for example BORDER_GRID to 30. Here is a better function. It notably makes the drawing of the background inside the code instead of as the background of the tilesets.
Created attachment 286509 [details] [review] Rename main code files. Patch unrelated with this bug, but as it’s quite difficult in Gedit to find Iagno’s game-view.vala & game.vala, I suggest renaming the main code files to iagno-main.vala, iagno-view.vala & iagno-game.vala.
Review of attachment 286507 [details] [review]: OK, except: ::: src/game-view.vala @@ +69,3 @@ public GameView () { + double_buffered = false; You can't do this because it won't work in Wayland. I'm surprised there wasn't a compiler warning for it.
Review of attachment 286509 [details] [review]: I know it's confusing if you work on multiple games at once, but I don't really like this... especially since you've renamed some of the files but not others. This naming convention works for games with short names, but what would you do for something like four-in-a-row: use a weird abbreviation like fiar-game?
Created attachment 286640 [details] [review] Better drawing function. Here is the update and rebase. (In reply to comment #29) > This naming convention works for games with short names, but what would you do > for something like four-in-a-row: use a weird abbreviation like fiar-game? Yes, that’s the name of the files in my wip vala rewrite, as it’s completely predictable.
OK, you can rename the files in another bug if you really want to, as long as you change them all. (Thanks for working on a Vala version!)
Long bug, time to summarize the remaining work: * Our green background doesn't have any texture (and * Our game pieces don't look like Allan's
Created attachment 301552 [details] [review] Think rounded square. Using this bug for asking advices about some (more) themes changes, adding rounded shapes. I’m quite happy with this patch, notably with the “Classic” theme, but I’m not sure I don’t play too much with the “Black and White” and “Adwaita” ones. An idea about that ?
Created attachment 302738 [details] [review] Radius 9 for some themes. I pushed the previous patch without the (big) changes to “Black and White” and “Adwaita”. Here is a patch to test these.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/iagno/issues/4.