After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710120 - accessibility: objects that represent arrows should be exposed with the role ATK_ROLE_ARROW
accessibility: objects that represent arrows should be exposed with the role ...
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.10.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-10-14 16:43 UTC by Alejandro Piñeiro Iglesias (IRC: infapi00)
Modified: 2013-10-14 20:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Solves the bug, against tag 3.10.0.1 (3.82 KB, patch)
2013-10-14 16:45 UTC, Alejandro Piñeiro Iglesias (IRC: infapi00)
rejected Details | Review
Solves the bug, against current master (778 bytes, patch)
2013-10-14 16:48 UTC, Alejandro Piñeiro Iglesias (IRC: infapi00)
committed Details | Review

Description Alejandro Piñeiro Iglesias (IRC: infapi00) 2013-10-14 16:43:12 UTC
There are several Labels around that represent arrows, using a special unicode value. Right now are exposed as ATK_ROLE_LABEL, but should be exposed as ATK_ROLE_ARROW. Why this makes sense is obvious. Why this is relevant is to avoid exposing that object as a label, as some braille displays doesn't work really well with unicode special chars like this.
Comment 1 Alejandro Piñeiro Iglesias (IRC: infapi00) 2013-10-14 16:45:15 UTC
Created attachment 257281 [details] [review]
Solves the bug, against tag 3.10.0.1

Being so trivial change, ideally this would be included for 3.10.1 release. I didn't find a gnome-3-10 branch, so I worked against the current 3.10.0.1 tag.
Comment 2 Alejandro Piñeiro Iglesias (IRC: infapi00) 2013-10-14 16:48:14 UTC
Created attachment 257282 [details] [review]
Solves the bug, against current master

All the arrow stuff was refactored recently [1], so the previous patch become really more simpler (one line) on master.

[1] https://git.gnome.org/browse/gnome-shell/commit/?id=63593e45a6a776bd44b596172a4e0efe99bf3e77
Comment 3 Florian Müllner 2013-10-14 16:53:27 UTC
Comment on attachment 257281 [details] [review]
Solves the bug, against tag 3.10.0.1

3.10.1 will be released from master, we'll branch afterwards.
Comment 4 Florian Müllner 2013-10-14 16:54:23 UTC
Review of attachment 257282 [details] [review]:

LGTM