After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710107 - Update Mallard page about Bookmarks
Update Mallard page about Bookmarks
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: User documentation
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Maintainers of Gnome user documentation
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-10-14 14:07 UTC by Tiffany Antopolski
Modified: 2013-11-04 10:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
help: Updated information on working with bookmarks. (2.29 KB, patch)
2013-11-04 04:42 UTC, Tiffany Antopolski 		committed Details | Review

Description Tiffany Antopolski 2013-10-14 14:07:04 UTC 
Current docs page about bookmarks says that bookmarks are not available.  This is not longer the case, so that page needs updating to current state.
Comment 1 Tiffany Antopolski 2013-11-04 04:42:53 UTC 
Created attachment 258898 [details] [review]
help: Updated information on working with bookmarks.
Comment 2 Allison Karlitskaya (desrt) 2013-11-04 04:47:01 UTC 
Review of attachment 258898 [details] [review]:

Looks good, aside from indentation (which was already broken in this file).
Comment 3 Tiffany Antopolski 2013-11-04 04:47:59 UTC 
Attachment 258898 [details] pushed as 180dde4 - help: Updated information on working with bookmarks.
Comment 4 Kat 2013-11-04 09:01:36 UTC 
(In reply to comment #2)
> Review of attachment 258898 [details] [review]:
> 
> Looks good, aside from indentation (which was already broken in this file).

I would generally recommend that indentation is fixed in any new additions to the page because well laid out pages are easier to maintain and don't look as scary to new contributors.

It also makes sense to use any new additions to demonstrate good practices.
Comment 5 Kat 2013-11-04 10:34:36 UTC 
I've had a look at the patch and it needed a few capitalisation fixups. Please make sure to capitalise proper names correctly and <gui> strings as they appear in the UI.

It is also helpful to update the <revision> tag to show that the page is valid for the current release.