After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710100 - rtsp-stream: Add functions to get sockets from GstRTSPStream objects
rtsp-stream: Add functions to get sockets from GstRTSPStream objects
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other Linux
: Normal normal
: 1.2.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-10-14 13:31 UTC by Jonas Holmberg
Modified: 2014-02-25 22:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add functions to get rtp and rtcp sockets from stream (5.45 KB, patch)
2013-10-14 13:34 UTC, Jonas Holmberg
reviewed Details | Review
Add functions to get rtp and rtcp v4 and v6 sockets (7.12 KB, patch)
2013-10-14 21:47 UTC, Jonas Holmberg
none Details | Review
Add functions to get rtp and rtcp sockets (8.06 KB, patch)
2013-10-15 07:29 UTC, Jonas Holmberg
rejected Details | Review
Add functions to get rtp and rtcp sockets (7.52 KB, patch)
2013-10-15 08:01 UTC, Jonas Holmberg
committed Details | Review

Description Jonas Holmberg 2013-10-14 13:31:41 UTC
To get the actual GSockets from an GstRTSPStream one would have to iterate the pipeline of the GstRTSPMedia and get the sockets from some the sinks in that pipeline. Adding functions to get the rtp and rtcp sockets directly from the stream objects would make it easier.
Comment 1 Jonas Holmberg 2013-10-14 13:34:25 UTC
Created attachment 257254 [details] [review]
Add functions to get rtp and rtcp sockets from stream
Comment 2 Sebastian Dröge (slomo) 2013-10-14 17:35:58 UTC
Comment on attachment 257254 [details] [review]
Add functions to get rtp and rtcp sockets from stream

Note that this a) only works if the stream is over UDP and b) for IPv4. For IPv6 there's the socket-v6 property. I think this needs to be adapted a bit.
Comment 3 Jonas Holmberg 2013-10-14 21:46:16 UTC
I forgot about IPv6. I don't think the stream sockets are of any interest when the stream is over TCP (it can be obtained from some other place then I think). I will add IPv6 and that would be enough I think.
Comment 4 Jonas Holmberg 2013-10-14 21:47:45 UTC
Created attachment 257309 [details] [review]
Add functions to get rtp and rtcp v4 and v6 sockets

Added v6-functions.
Comment 5 Jonas Holmberg 2013-10-15 07:29:38 UTC
Created attachment 257322 [details] [review]
Add functions to get rtp and rtcp sockets

Modified unittest to not require both IPv4 and IPv6 sockets.
Comment 6 Sebastian Dröge (slomo) 2013-10-15 07:39:41 UTC
Maybe this should be renamed get_rtp_udp_socket() or something like that?
Comment 7 Jonas Holmberg 2013-10-15 08:01:05 UTC
Created attachment 257327 [details] [review]
Add functions to get rtp and rtcp sockets

Alternative implementation using family argument instead of v6-specific functions.
Comment 8 Wim Taymans 2013-11-12 11:05:51 UTC
commit 8d5ce0d4ee6b99139de64372b5138ac6f8088611
Author: Wim Taymans <wim.taymans@gmail.com>
Date:   Tue Nov 12 12:04:55 2013 +0100

    stream: Add functions to get rtp and rtcp sockets
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=710100