After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710069 - pkcs11: fix racy build
pkcs11: fix racy build
Status: RESOLVED FIXED
Product: seahorse
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Seahorse Maintainer
Seahorse Maintainer
Depends on:
Blocks:
 
 
Reported: 2013-10-13 21:45 UTC by Michael Catanzaro
Modified: 2013-10-19 01:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
pkcs11: fix racy build (1.08 KB, patch)
2013-10-13 21:45 UTC, Michael Catanzaro 		none Details | Review

Description Michael Catanzaro 2013-10-13 21:45:23 UTC 
seahorse-pkcs11.h needs to be generated before attempting to compile libseahorse_pkcs11_la, but there's no mechanism in seahorse/pkcs11/Makefile.am to enforce this.  Clean builds fail randomly.

I am fairly confident the attached patch fixes the issue.

Be careful if you want to look for a more elegant solution: I tried lots of other "fixes" before I hit on this one.
Comment 1 Michael Catanzaro 2013-10-13 21:45:25 UTC 
Created attachment 257197 [details] [review]
pkcs11: fix racy build

seahorse-pkcs11.h needs to be built before the files that include it are
compiled. Unfortunately it is generated by valac, and there doesn't seem
to be any simple way to tell this to Automake. But adding the Vala stamp
file to BUILT_SOURCES tells it to compile the Vala before doing anything
else, which is what we need.