Created attachment 257187 [details] [review]
use xchat-gnome accelerators

Make transition from xchat-gnome easier.

(In reply to comment #0)
> Any chance I can convince you to use xchat-gnome accelerators? :)

While we are not technically using tabs, the use case is sufficiently close IMHO to justify the reuse of the standard GNOME shortcuts. So how about adding the xchat ones rather than replacing the current ones?

I should probably add that xchat (e.g. not xchat-gnome) uses ctrl-pgUp/pgDown as well ...

(In reply to comment #2)
> (In reply to comment #0)
> > Any chance I can convince you to use xchat-gnome accelerators? :)
> 
> While we are not technically using tabs, the use case is sufficiently close
> IMHO to justify the reuse of the standard GNOME shortcuts. So how about adding
> the xchat ones rather than replacing the current ones?

Yeah adding would be best, but gtk_application_add_accelerator() doesn't allow us to have more than one accelerator for the same action.
Is it possible to do so or should we add "fake" actions?

Created attachment 269965 [details] [review]
app: Provide some xchat-gnome compatibility shortcuts

Muscle memory and stuff ...


Whoops, had this lying around for ages and forgot to attach it :-(

Created attachment 285831 [details] [review]
app: Use set_accels_for_action()

GtkApplication.add_accelerator() has been deprecated in favor of
set_accels_for_action(), which has the added benefit of supporting
multiple accels per action.

Created attachment 285832 [details] [review]
app: Provide some xchat-gnome compatibility shortcuts

Muscle memory and stuff ...

We got a non-hacky way of having multiple accels per action this cycle, so let's do this now ...

Attachment 285831 [details] pushed as 5825c2e - app: Use set_accels_for_action()
Attachment 285832 [details] pushed as b26ca6e - app: Provide some xchat-gnome compatibility shortcuts