After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710028 - error on checkmate
error on checkmate
Status: RESOLVED FIXED
Product: gnome-chess
Classification: Applications
Component: General
3.10.x
Other Linux
: High normal
: ---
Assigned To: gnome-chess-maint
gnome-chess-maint
Depends on:
Blocks:
 
 
Reported: 2013-10-13 07:29 UTC by Antony Williams
Modified: 2013-10-13 19:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gnome-chess doesn't recognise checkmate (38.65 KB, image/png)
2013-10-13 07:29 UTC, Antony Williams
  Details
Game: Stop should be no-op if already stopped (861 bytes, patch)
2013-10-13 19:00 UTC, Michael Catanzaro
committed Details | Review
Don't declare error immediately after engine quits (1.42 KB, patch)
2013-10-13 19:10 UTC, Michael Catanzaro
committed Details | Review

Description Antony Williams 2013-10-13 07:29:02 UTC
Created attachment 257158 [details]
gnome-chess doesn't recognise checkmate

Kind of funny that a chess program doesn't recognise checkmate. Instead it just errors out and says "Opps Something has gone wrong. The game cannot continue.
Comment 1 Michael Catanzaro 2013-10-13 15:16:54 UTC
Thanks for reporting this bug.  Also, oops.

Can you please tell me what engine you're playing against?  (Application menu -> Preferences -> "Opposing player")
Comment 2 Antony Williams 2013-10-13 16:30:48 UTC
Stockfish - Easy -  No limit
Comment 3 Michael Catanzaro 2013-10-13 19:00:22 UTC
Created attachment 257192 [details] [review]
Game: Stop should be no-op if already stopped

We're stopping multiple times in a row.  game_end_cb is followed by
engine_stopped_cb, causing "Oops! Something has gone wrong!"
Comment 4 Michael Catanzaro 2013-10-13 19:10:15 UTC
Created attachment 257194 [details] [review]
Don't declare error immediately after engine quits

Chill out a moment or two. Don't lose the race between the ChildWatch
and the IOWatch.
Comment 5 Michael Catanzaro 2013-10-13 19:15:29 UTC
Should be fixed. Unfortunately this missed 3.10.1 because I released it early, but this is significant enough to warrant a 3.10.1.1.  (There was also a separate bug affecting CECP engines only.)

Attachment 257192 [details] pushed as 19baf0f - Game: Stop should be no-op if already stopped
Attachment 257194 [details] pushed as 749c36d - Don't declare error immediately after engine quits