After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710011 - Fix observations of existing channels
Fix observations of existing channels
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2013-10-12 19:56 UTC by Guillaume Desmottes
Modified: 2013-10-12 21:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
make sure to prepare TP_CHANNEL_FEATURE_CONTACTS (978 bytes, patch)
2013-10-12 20:02 UTC, Guillaume Desmottes 		committed Details | Review
properly check if we are invited to a room (1.64 KB, patch)
2013-10-12 20:03 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2013-10-12 19:56:50 UTC 
Polari currently ignore all of my already connected channels wrongly assuming I have been invited to join them.
Comment 1 Guillaume Desmottes 2013-10-12 20:02:02 UTC 
Created attachment 257120 [details] [review]
make sure to prepare TP_CHANNEL_FEATURE_CONTACTS
Comment 2 Guillaume Desmottes 2013-10-12 20:03:06 UTC 
Created attachment 257121 [details] [review]
properly check if we are invited to a room
Comment 3 Florian Müllner 2013-10-12 20:11:33 UTC 
Review of attachment 257120 [details] [review]:

OK
Comment 4 Florian Müllner 2013-10-12 20:14:10 UTC 
Review of attachment 257121 [details] [review]:

Style comment, feel free to ignore if you disagree.

::: src/chatroomManager.js
@@ +132,3 @@
             function(channel) {
+                if (channel.has_interface(Tp.IFACE_CHANNEL_INTERFACE_GROUP)) {
+                    let [invited, lp, actor, reason, msg] = channel.group_get_local_pending_contact_info(channel.group_self_contact);

I'd prefer
  let [invited, , , ,] = ...
as you're not using any of the other return values.
Comment 5 Guillaume Desmottes 2013-10-12 21:46:42 UTC 
Changed and merged to master.

Attachment 257120 [details] pushed as ee26daa - make sure to prepare TP_CHANNEL_FEATURE_CONTACTS
Attachment 257121 [details] pushed as 4b42726 - properly check if we are invited to a room