After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709998 - NotificationDaemon: fix icons for notifications without an app
NotificationDaemon: fix icons for notifications without an app
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-10-12 17:00 UTC by Giovanni Campagna
Modified: 2013-10-12 23:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
NotificationDaemon: fix icons for notifications without an app (1.35 KB, patch)
2013-10-12 17:00 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2013-10-12 17:00:00 UTC 
NotificationDaemon doesn't pass a gicon to the Notification constructor,
because it calls .update() immediately after, so messageTray.js
calls into Source.createIcon(), which returns null and crashes.
Instead, shortcut the Notification constructor by skipping
.update() completely.
Comment 1 Giovanni Campagna 2013-10-12 17:00:03 UTC 
Created attachment 257111 [details] [review]
NotificationDaemon: fix icons for notifications without an app
Comment 2 drago01 2013-10-12 18:40:19 UTC 
Review of attachment 257111 [details] [review]:

OK.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-10-12 18:45:51 UTC 
wait, why does Source.createIcon fail? The source should always have an icon, even if it's a generic 'lightbulb' fallback icon.
Comment 4 Giovanni Campagna 2013-10-12 18:50:35 UTC 
no it returns null sometimes.

But even if we fix createIcon(), shortcutting the update() makes sense to me
Comment 5 Giovanni Campagna 2013-10-12 23:28:30 UTC 
Attachment 257111 [details] pushed as 619389e - NotificationDaemon: fix icons for notifications without an app