GNOME Bugzilla – Bug 709956
spell check support
Last modified: 2017-01-31 14:11:15 UTC
it would be nice to have
1. Gtkspell doesn't support gjs as far as I now. 2. Build-in GTK spellcheck in progress, however we don't know if it's going to happen soon: https://mail.gnome.org/archives/gtk-devel-list/2013-October/msg00025.html
*** Bug 735528 has been marked as a duplicate of this bug. ***
Would be nice indeed. Is it possible to use gspell for this?
Not off-the-shelf. We'd need to either add support for GtkEntry to GSpell, or replace the entry with a custom entry-like widget based on GtkTextView.
Created attachment 344576 [details] [review] entryArea: Spell check entry Gspell recently gained GtkEntry support, so we finally have a simple standard way to add spelling support.
Review of attachment 344576 [details] [review]: code looks good to me, one question ::: configure.ac @@ +49,3 @@ AX_CHECK_GIR_SYMBOLS_GJS([GLib], [2.0], [log_variant]) AX_CHECK_GIRS_GJS([GObject], [2.0]) +AX_CHECK_GIR_SYMBOLS_GJS([Gspell], [1], [Entry]) this shouldnt say "1.0" ? i just notice all the other AX_CHECKs uses 1
(In reply to Bastian Ilsø from comment #6) > +AX_CHECK_GIR_SYMBOLS_GJS([Gspell], [1], [Entry]) > > this shouldnt say "1.0" ? i just notice all the other AX_CHECKs uses 1 The version string needs to match the version used by the gir/typelib. Pretty much all libraries use the ".0" notation, except for Gspell which doesn't follow that convention (admittedly it's a pointless one, given that the minor version is never bumped anyway).
(In reply to Florian Müllner from comment #7) > (In reply to Bastian Ilsø from comment #6) > > +AX_CHECK_GIR_SYMBOLS_GJS([Gspell], [1], [Entry]) > > > > this shouldnt say "1.0" ? i just notice all the other AX_CHECKs uses 1 > > The version string needs to match the version used by the gir/typelib. > Pretty much all libraries use the ".0" notation, except for Gspell which > doesn't follow that convention (admittedly it's a pointless one, given that > the minor version is never bumped anyway). ah ok, then lets do this :-)
Review of attachment 344576 [details] [review]: lgtm
Attachment 344576 [details] pushed as 1455d21 - entryArea: Spell check entry