After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709956 - spell check support
spell check support
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: Polari maintainers
Polari maintainers
: 735528 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-10-11 23:20 UTC by Jonh Wendell
Modified: 2017-01-31 14:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
entryArea: Spell check entry (2.17 KB, patch)
2017-01-30 19:37 UTC, Florian Müllner
committed Details | Review

Description Jonh Wendell 2013-10-11 23:20:01 UTC
it would be nice to have
Comment 1 Daniel Korostil 2013-10-15 19:08:46 UTC
1. Gtkspell doesn't support gjs as far as I now.

2. Build-in GTK spellcheck in progress, however we don't know if it's going to happen soon: https://mail.gnome.org/archives/gtk-devel-list/2013-October/msg00025.html
Comment 2 Florian Müllner 2014-08-27 16:10:30 UTC
*** Bug 735528 has been marked as a duplicate of this bug. ***
Comment 3 Allan Day 2016-04-01 09:39:38 UTC
Would be nice indeed. Is it possible to use gspell for this?
Comment 4 Florian Müllner 2016-04-01 10:18:43 UTC
Not off-the-shelf. We'd need to either add support for GtkEntry to GSpell, or replace the entry with a custom entry-like widget based on GtkTextView.
Comment 5 Florian Müllner 2017-01-30 19:37:44 UTC
Created attachment 344576 [details] [review]
entryArea: Spell check entry

Gspell recently gained GtkEntry support, so we finally have a simple
standard way to add spelling support.
Comment 6 Bastian Ilsø 2017-01-30 22:39:44 UTC
Review of attachment 344576 [details] [review]:

code looks good to me, one question

::: configure.ac
@@ +49,3 @@
 AX_CHECK_GIR_SYMBOLS_GJS([GLib], [2.0], [log_variant])
 AX_CHECK_GIRS_GJS([GObject], [2.0])
+AX_CHECK_GIR_SYMBOLS_GJS([Gspell], [1], [Entry])

this shouldnt say "1.0" ? i just notice all the other AX_CHECKs uses 1
Comment 7 Florian Müllner 2017-01-30 22:46:32 UTC
(In reply to Bastian Ilsø from comment #6)
> +AX_CHECK_GIR_SYMBOLS_GJS([Gspell], [1], [Entry])
> 
> this shouldnt say "1.0" ? i just notice all the other AX_CHECKs uses 1

The version string needs to match the version used by the gir/typelib. Pretty much all libraries use the ".0" notation, except for Gspell which doesn't follow that convention (admittedly it's a pointless one, given that the minor version is never bumped anyway).
Comment 8 Bastian Ilsø 2017-01-30 22:49:04 UTC
(In reply to Florian Müllner from comment #7)
> (In reply to Bastian Ilsø from comment #6)
> > +AX_CHECK_GIR_SYMBOLS_GJS([Gspell], [1], [Entry])
> > 
> > this shouldnt say "1.0" ? i just notice all the other AX_CHECKs uses 1
> 
> The version string needs to match the version used by the gir/typelib.
> Pretty much all libraries use the ".0" notation, except for Gspell which
> doesn't follow that convention (admittedly it's a pointless one, given that
> the minor version is never bumped anyway).

ah ok, then lets do this :-)
Comment 9 Bastian Ilsø 2017-01-30 22:49:32 UTC
Review of attachment 344576 [details] [review]:

lgtm
Comment 10 Florian Müllner 2017-01-31 14:11:08 UTC
Attachment 344576 [details] pushed as 1455d21 - entryArea: Spell check entry