After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709953 - a kerberos crasher fix
a kerberos crasher fix
Status: RESOLVED FIXED
Product: gnome-online-accounts
Classification: Core
Component: Kerberos
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Online Accounts maintainer(s)
GNOME Online Accounts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-10-11 23:18 UTC by Ray Strode [halfline]
Modified: 2013-10-14 18:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
goaalarm: add locks when setting up timers (1.77 KB, patch)
2013-10-11 23:18 UTC, Ray Strode [halfline] 		none Details | Review
goaalarm: add locks when setting up timers (2.78 KB, patch)
2013-10-11 23:25 UTC, Ray Strode [halfline] 		committed Details | Review

Description Ray Strode [halfline] 2013-10-11 23:18:05 UTC 
This is more fallout from bug 705395 I think.
We still can end up in a situation where we're setting the alarm in on thread while clearing in another, so we need to add synchronization.
Comment 1 Ray Strode [halfline] 2013-10-11 23:18:06 UTC 
Created attachment 257064 [details] [review]
goaalarm: add locks when setting up timers

An alarm could be getting set in one thread while getting
cleared in another.  We need to protect against that.
Comment 2 Ray Strode [halfline] 2013-10-11 23:25:58 UTC 
Created attachment 257066 [details] [review]
goaalarm: add locks when setting up timers

An alarm could be getting set in one thread while getting
cleared in another.  We need to protect against that.
Comment 3 Ray Strode [halfline] 2013-10-11 23:29:22 UTC 
i thought about it more, and the updated patch expands the lock to cover all the related state (such as the expiration time itself), not just the timer sources.
Comment 4 Debarshi Ray 2013-10-14 16:03:10 UTC 
Review of attachment 257066 [details] [review]:

Looks fine to me. Didn't encounter any breakage after a round of testing.
Comment 5 Ray Strode [halfline] 2013-10-14 18:09:44 UTC 
Attachment 257066 [details] pushed as 0abe062 - goaalarm: add locks when setting up timers