After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709950 - Keep the focus in message entry
Keep the focus in message entry
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2013-10-11 23:11 UTC by Jonh Wendell
Modified: 2013-10-12 10:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
mainWindow: Try harder to keep focus on the main entry (2.57 KB, patch)
2013-10-11 23:42 UTC, Florian Müllner
committed Details | Review

Description Jonh Wendell 2013-10-11 23:11:19 UTC
if I click on a channel on the left panel, the focus should stay at the typing entry.
Comment 1 Florian Müllner 2013-10-11 23:42:41 UTC
Created attachment 257067 [details] [review]
mainWindow: Try harder to keep focus on the main entry

In general, we want the keyboard focus to remain on the main entry
so users don't have to explicitly focus it to write a message. The
only exceptions are:

 - focusing a different entry (nick entry, user list filter in the
   future)
 - using keynav

Unfortunately many widgets will grab the keyboard focus when activated,
and making them unfocusable would break accessibility. So resort to
a hack which forces focus back to the entry unless we detect one of
the exceptions above.
Comment 2 Florian Müllner 2013-10-12 10:30:46 UTC
Attachment 257067 [details] pushed as 5a50f25 - mainWindow: Try harder to keep focus on the main entry

It works reasonably well in testing, so let's go with this for now.