GNOME Bugzilla – Bug 709943
yelp-xsl/xslt/common/html.xsl missing a fundamental docbook tag conversion
Last modified: 2014-02-04 17:37:35 UTC
In Ubuntu-docs, both the DeskTop help and serverguide, the compiled HTML does not differentiate or emphasize some tag pairs as used to occur with the older theme. An example of the issue is the fundamental docbook tag pair <keycap></keycap> doesn't get converted properly. However, I think the root issue is that these lines are missing from /usr/share/yelp-xsl/xslt/common/html.xsl: span.key { font-weight: bold; } a suggested good place for them would be right around these lines: span.key a { border-bottom: none; } Note: This issue has a workaround in that we have added those missing lines to our ubuntu.xsl files. Ubuntu Launchpad bug report reference: https://bugs.launchpad.net/serverguide/+bug/1173426
Thanks for reporting this. Would you be able to provide a patch against git master of yelp-xsl?
(In reply to comment #1) > Thanks for reporting this. Would you be able to provide a patch against git > master of yelp-xsl? No.
Problem is I switched the Mallard transforms to use <kbd> for <mal:key>, and changed the common CSS to reflect it: https://git.gnome.org/browse/yelp-xsl/commit/?id=e4e160b2e4ab311e9c7a0a186adeb1b39da2de49 But I didn't change <db:keycap> over to use <kbd>, so it lost its styling.
I tried yelp-xsl version 3.11.5. I didn't see the lines mentioned above added to html.xsl, nor was the desired effect present in the compiled html document after removing the workaround in ubuntu.xsl.
The styling is done on the kdb element, not span.key. That's what the Mallard transforms switched to back in 2011 when I broke the DocBook styling. The DocBook transforms now output a kbd element, so they should pick up the styling. It's not "font-weight: bold". If that's how you want keys to be styled, then you need to maintain custom css for the HTML kdb element. Attaching a patch of what it should look like.
Created attachment 268085 [details] Screenshot of keycap styling
Shaun thanks for your comments and the time you took to look into this. For whatever reason, in the ubuntu serverguide the styling is almost imperceptible. I will leave the overrides I added to the both the Ubuntu Desktop and Serverguides ubuntu.xsl files in place. All I was trying to do was make things look similar to what they looked like a few years ago and make it obvious that it was a "key".