After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709933 - channel list – markup in channel names needs to be escaped
channel list – markup in channel names needs to be escaped
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2013-10-11 18:43 UTC by Mantas Mikulėnas (grawity)
Modified: 2013-10-12 19:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
roomList: Don't use markup in room label (1.24 KB, patch)
2013-10-12 19:50 UTC, Florian Müllner 		committed Details | Review

Description Mantas Mikulėnas (grawity) 2013-10-11 18:43:58 UTC 
When I join "#<b>test&amp;test</b>" it shows up as "test&test" in the channel list – in bold.

When I join "#test&test" it shows up as an empty row, and the following warning is printed:

(polari:162499): Gtk-WARNING **: Failed to set text from markup due to error parsing markup: Error on line 1: Entity did not end with a semicolon; most likely you used an ampersand character without intending to start an entity - escape ampersand as &amp;
Comment 1 Florian Müllner 2013-10-12 19:50:45 UTC 
Created attachment 257119 [details] [review]
roomList: Don't use markup in room label

A bold room label used to indicate highlighted messages in the
corresponding channel; since commit cb69f7d3a62 this is no longer
the case, so stop using markup altogether - this will also relieve
us from escaping any markup from the room name.
Comment 2 Florian Müllner 2013-10-12 19:51:07 UTC 
Attachment 257119 [details] pushed as c7ff4c1 - roomList: Don't use markup in room label