After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709918 - Horizontal padding needed around header bar titles
Horizontal padding needed around header bar titles
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
3.10.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-10-11 15:33 UTC by Allan Day
Modified: 2013-12-15 03:00 UTC
See Also:
GNOME target: ---
GNOME version: 3.11/3.12

Attachments
screenshot (274.87 KB, image/png)
2013-10-11 15:33 UTC, Allan Day 		  Details
Header bar after padding applied (16.86 KB, image/png)
2013-10-16 20:34 UTC, Pierre-Yves Luyten 		  Details
Add 12px hpadding to header bar (1.43 KB, patch)
2013-10-16 20:35 UTC, Pierre-Yves Luyten 		none Details | Review

Description Allan Day 2013-10-11 15:33:00 UTC 
Created attachment 257013 [details]
screenshot

Look at the attached screenshot - the title gets far too close to the buttons on either side. I would add padding of at least 12px to either side.
Comment 1 Pierre-Yves Luyten 2013-10-16 20:34:37 UTC 
Created attachment 257449 [details]
Header bar after padding applied

Show header bar with some padding
Comment 2 Pierre-Yves Luyten 2013-10-16 20:35:28 UTC 
Created attachment 257450 [details] [review]
Add 12px hpadding to header bar

Use gtk misc hpadding
Comment 3 Pierre-Yves Luyten 2013-10-16 20:38:02 UTC 
Re-assigning to gtk+, since this is internal to headerbar.

I believe using hpadding for title and subtitle GtkMisc is fine and attached patch could be applied. Attached screenshot ("... after padding ..") shows the difference.
Comment 4 Allan Day 2013-10-16 21:52:46 UTC 
Much better! :)
Comment 5 Matthias Clasen 2013-12-12 22:30:09 UTC 
How about setting up css padding for the title and subtitle styles that those labels use, instead ?