GNOME Bugzilla – Bug 709900
Don’t return outdated thumbnails for local files
Last modified: 2013-11-05 08:00:54 UTC
Grilo currently happily returns old thumbnails for files which have been modified since, which is incorrect. Using the G_FILE_ATTRIBUTE_THUMBNAIL_IS_VALID attribute from bug #709898, patch coming up to only return thumbnails which are valid (i.e. up to date with respect to the current contents of the media file). This bumps Grilo’s GIO dependency to 2.39.0. I could make the changes conditionally compiled and avoid the dependency bump, though, if desired.
Created attachment 256989 [details] [review] filesystem: Only return thumbnails if they’re valid/up to date Use G_FILE_ATTRIBUTE_THUMBNAIL_IS_VALID to ensure that only up to date thumbnails are returned by the filesystem and local-metadata plugins. This requires a GIO dependency bump to 2.39.0.
Philip, sorry for the delay. Could you do changes conditionally? GIO 2.39.0 is pretty new, and nobody is still using it. It would be great to not hard-depend on this so we can use new releases in current distributions.
Created attachment 258635 [details] [review] filesystem: Only return thumbnails if they’re valid/up to date Use G_FILE_ATTRIBUTE_THUMBNAIL_IS_VALID to ensure that only up to date thumbnails are returned by the filesystem and local-metadata plugins. This uses an optional GIO dependency bump to 2.39.0. If that version of GIO isn’t available, the new functionality won’t be used.
commit 41594ba590ab1115b48e3d1182c4a6673c0c79c2 Author: Philip Withnall <philip.withnall@collabora.co.uk> Date: Fri Oct 11 11:31:42 2013 +0100 filesystem: Only return thumbnails if they’re valid/up to date Use G_FILE_ATTRIBUTE_THUMBNAIL_IS_VALID to ensure that only up to date thumbnails are returned by the filesystem and local-metadata plugins. This uses an optional GIO dependency bump to 2.39.0. If that version of GIO isn’t available, the new functionality won’t be used. https://bugzilla.gnome.org/show_bug.cgi?id=709900 src/filesystem/grl-filesystem.c | 23 ++++++++++++++++++++--- src/local-metadata/grl-local-metadata.c | 29 ++++++++++++++++++++++++----- 2 files changed, 44 insertions(+), 8 deletions(-)