GNOME Bugzilla – Bug 709896
Close button shouldn't be present on selection mode
Last modified: 2015-03-26 13:28:20 UTC
Created attachment 256984 [details] polari close on selection See attached screenshot. Relative design for documents and music: https://raw.github.com/gnome-design-team/gnome-mockups/master/documents/documents-actions-list.png https://raw.github.com/gnome-design-team/gnome-mockups/master/music/music-list-actions.png
Created attachment 257003 [details] [review] mainWindow: Don't show close button in selection mode The current design pattern regarding selection mode is to hide the window's close button while it's active, so let's follow that ...
Our pattern is slightly different in that selection mode really is limited to the sidebar rather than the entire window - so I don't see us putting a "Done" or "Cancel" button in place of the normal close button (if we wanted it, we should put it in the sidebar, but as space is limited there, we use a toggle button). In any case, if we want to still follow the pattern, we need to hide the user-list button as well in that case (bug 709395), otherwise the button jumps around depending on the visibility of the close button.
Created attachment 257021 [details] [review] mainWindow: Don't show close button in selection mode
The reason why the selection mode doesn't have a close window button in the "no sidebar" case is a potentially destructive confusion. You might be wanting to cancel the selection bode and hitting the x button closes the window instead with no way to undo that action. In the case of sidebar, this potential confusion is much lower. I don't think we need to disable the close action here, although I wouldn't be opposed as it is consistent with the single headerbar case. Maybe a second option? Allan?
opinion, not option :*)
It's not the only reason. Selection mode means that we are changing settings, so we shouldn't be able to close it in the middle of configuring, because we have two options: 1. it'll require the saving dialogue anyway., so we have to click Save or Cancel before Close. 2. if not - there is no warning dialogue - we'll lose our settings. Neither of this cases make sense to show Close button, IMHO.
(In reply to comment #6) > It's not the only reason. Selection mode means that we are changing settings, > so we shouldn't be able to close it in the middle of configuring, because we > have two options: > 1. it'll require the saving dialogue anyway., so we have to click Save or > Cancel before Close. > 2. if not - there is no warning dialogue - we'll lose our settings. What settings are you talking about? We use selection mode exclusively to leave channels, and the only thing changing is the selection of marked channels. Closing the window in that case behaves exactly like canceling selection mode and closing the window after that, e.g. no channel is left and whatever channels you had open will be restored the next time polari is started. (Note that hiding the close button will not prevent you from closing the window in any case - there's still "quit" in the app menu, the close button in the overview and alt-f4 ...)
Okay, just my two cents: 1. It shouldn't disturb users while they act in selection mode (they pay more attention to headerbar, usually they don't want to close the window in this mode). 2. It's not so common look'n'feel compared to other apps with selection mode. 3. Speaking on Alt+F4,Quit in the app menu and in overview. If we have so much options, why should we care about the fact we hide it somewhere within the app. 4. If we want to leave it there, it also means we have a theme issue (different separators style).
FWIW, I'm not opposed of hiding the button, but not "just because" (In reply to comment #8) > Okay, just my two cents: > 1. It shouldn't disturb users while they act in selection mode (they pay more > attention to headerbar, usually they don't want to close the window in this > mode). Our selection mode is limited to the left sidebar, which is opposite to the close button - I don't see much potential for distraction there (at least much less than the still visible chat log where new messages could arrive during selection mode etc) > 2. It's not so common look'n'feel compared to other apps with selection mode. I just checked with gnome-contacts (which is the only other app I can think of that uses selection mode for its sidebar), and it doesn't hide the close button either. I think "selection-mode-for-main-view" and "selection-mode-for-sidebar" are sufficiently different to justify some differences in behavior as well. > 3. Speaking on Alt+F4,Quit in the app menu and in overview. If we have so much > options, why should we care about the fact we hide it somewhere within the app. You haven't seen the miriad of bug reports we got for not having a close button on maximized windows that hide their titlebar :-) (Plus a dozen duplicated bugs or so for moving the close button to the shell's top bar) > 4. If we want to leave it there, it also means we have a theme issue (different > separators style). This sounds like a bug that should be fixed whether or not we hide the close button ...
We removed selection mode in 3.16, so this is no longer an issue either way.