After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709889 - Topic can't be selected and copied
Topic can't be selected and copied
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2013-10-11 08:44 UTC by Daniel Korostil
Modified: 2013-10-14 17:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
topic screenshoot (26.64 KB, image/png)
2013-10-11 08:44 UTC, Daniel Korostil
  Details
ui: Use a custom title widget in header bar (5.88 KB, patch)
2013-10-13 00:57 UTC, Florian Müllner
none Details | Review
ui: Use a custom title widget in header bar (5.88 KB, patch)
2013-10-13 01:01 UTC, Florian Müllner
committed Details | Review
chatView: Move findUrls() to utils (5.12 KB, patch)
2013-10-13 01:01 UTC, Florian Müllner
committed Details | Review
mainWindow: Turn URLs in topics into clickable links (1.99 KB, patch)
2013-10-13 01:01 UTC, Florian Müllner
committed Details | Review

Description Daniel Korostil 2013-10-11 08:44:59 UTC
Created attachment 256977 [details]
topic screenshoot

It's very useful to copy the URL from topic or make it clickable like in chatzilla:
https://addons.cdn.mozilla.net/img/uploads/previews/full/41/41015.png?modified=1331247702

Also it'd cool to change Topic in this way if you have permissions.
Comment 1 Florian Müllner 2013-10-11 16:52:39 UTC
(In reply to comment #0)
> It's very useful to copy the URL from topic or make it clickable

I don't think making it selectable is a good idea - it is part of the titlebar, so we should leave some space for dragging the window. Making URLs clickable sounds like a good idea to me though.


> Also it'd cool to change Topic in this way if you have permissions.

If you have permissions, you can already change the topic using /topic - not sure it's a feature that needs more prominent exposure, I'll leave that to the designers to judge :-)
Comment 2 Florian Müllner 2013-10-13 00:57:36 UTC
Created attachment 257137 [details] [review]
ui: Use a custom title widget in header bar

GtkHeaderBar's title/subtitle behavior is very close to what we want,
except that it does not allow markup for either property. However as
channel topics frequently contain URLs, this is something we depend on
in order to display URLs as clickable links, so replace GtkHeaderBar's
default title with a custom widget which replicates the built-in
behavior, but parses markup in subtitles.
Comment 3 Florian Müllner 2013-10-13 01:01:09 UTC
Created attachment 257138 [details] [review]
ui: Use a custom title widget in header bar

GtkHeaderBar's title/subtitle behavior is very close to what we want,
except that it does not allow markup for either property. However as
channel topics frequently contain URLs, this is something we depend on
in order to display URLs as clickable links, so replace GtkHeaderBar's
default title with a custom widget which replicates the built-in
behavior, but parses markup in subtitles.
Comment 4 Florian Müllner 2013-10-13 01:01:17 UTC
Created attachment 257139 [details] [review]
chatView: Move findUrls() to utils

We will use it to identify links in topics.
Comment 5 Florian Müllner 2013-10-13 01:01:25 UTC
Created attachment 257140 [details] [review]
mainWindow: Turn URLs in topics into clickable links

Channel topics commonly contain URLs, which we currently display
as plain (and as part of the window decoration: unselectable) text.
Turn them into proper links instead to allow users to easily follow
them.
Comment 6 Florian Müllner 2013-10-14 17:58:41 UTC
Attachment 257138 [details] pushed as 37116a8 - ui: Use a custom title widget in header bar
Attachment 257139 [details] pushed as c45096c - chatView: Move findUrls() to utils
Attachment 257140 [details] pushed as 6dfbe3c - mainWindow: Turn URLs in topics into clickable links