Created attachment 256950 [details] [review]
notificationDaemon: Raise the app when clicking on a notification, not the MRU window

Created attachment 256951 [details] [review]
notificationDaemon: Close the message tray when trying to raise an app

Review of attachment 256950 [details] [review]:

If you don't go through Main.activateWindow(), you need to close the overview manually.

Review of attachment 256951 [details] [review]:

Yes

Review of attachment 256951 [details] [review]:

No, wait, the SummaryItem code emits done-displaying-content when you click on the notification, which closes the tray.
Or at least, it used to do that...

(In reply to comment #5)
> No, wait, the SummaryItem code emits done-displaying-content when you click on
> the notification, which closes the tray.
> Or at least, it used to do that...

I see done-display-content emitted in three places: when you click on "Open" on the right-click menu, when you click on "Remove" on the right-click menu, and when you click on the close button itself.

Nothing for clicking on any actions or the notification itself.

(Though clearly special-casing clicking on a notificationDaemon notification and not one one of its actions is wrong. I'll ask Jon about correct behavior, as it might get tricky with stacked notifications)

Attachment 256950 [details] pushed as 0892065 - notificationDaemon: Raise the app when clicking on a notification, not the MRU window


pushed this one with fixes for now. will file with a message tray patch eventually