After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709862 - Use search-bar style class for query editor
Use search-bar style class for query editor
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks: 709863
 
 
Reported: 2013-10-10 20:28 UTC by William Jon McCann
Modified: 2013-12-02 21:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use search-bar style class for query editor (1.31 KB, patch)
2013-10-10 20:28 UTC, William Jon McCann 		committed Details | Review
screenshot (with rows using search-bar) - red for effect (11.16 KB, image/png)
2013-11-15 19:07 UTC, William Jon McCann 		  Details
screenshot (with rows not using search-bar) - red for effect (8.60 KB, image/png)
2013-11-15 19:07 UTC, William Jon McCann 		  Details

Description William Jon McCann 2013-10-10 20:28:36 UTC 
Currently we rely on primary toolbar styling for the query editor. GTK+
master now has a search-bar style class. This seems more appropriate for the
query editor.
Comment 1 William Jon McCann 2013-10-10 20:28:38 UTC 
Created attachment 256946 [details] [review]
Use search-bar style class for query editor
Comment 2 Cosimo Cecchi 2013-10-10 20:51:17 UTC 
Review of attachment 256946 [details] [review]:

::: src/nautilus-query-editor.c
@@ +853,3 @@
 	row->toolbar = gtk_toolbar_new ();
+	gtk_style_context_add_class (gtk_widget_get_style_context (row->toolbar),
+				     "search-bar");

I don't think this style class is really needed on the row widgets, as they don't have a search entry on them.
Comment 3 William Jon McCann 2013-11-15 19:07:11 UTC 
Created attachment 259937 [details]
screenshot (with rows using search-bar) - red for effect 

They extend the search bar though. I don't think it makes sense to have them be distinct bars.
Comment 4 William Jon McCann 2013-11-15 19:07:38 UTC 
Created attachment 259938 [details]
screenshot (with rows not using search-bar) - red for effect
Comment 5 William Jon McCann 2013-12-02 21:39:45 UTC 
I pushed this after checking with jimmac that this makes sense.

<jimmac> mccann, makes sense. they both get revealed temporarily and are on the same "level"