After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709832 - max DEBUG_LEVEL Incongruence on docs & autocompletion logic between 5 and 9
max DEBUG_LEVEL Incongruence on docs & autocompletion logic between 5 and 9
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other All
: Normal minor
: 1.2.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2013-10-10 15:53 UTC by Reynaldo H. Verdejo Pinochet
Modified: 2013-10-11 08:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Proposed fix (3.39 KB, patch)
2013-10-10 15:53 UTC, Reynaldo H. Verdejo Pinochet
committed Details | Review

Description Reynaldo H. Verdejo Pinochet 2013-10-10 15:53:27 UTC
Created attachment 256924 [details] [review]
Proposed fix

Patch attached. OK to commit?
Comment 1 Sebastian Dröge (slomo) 2013-10-10 19:58:52 UTC
Comment on attachment 256924 [details] [review]
Proposed fix

Go ahead :)
Comment 2 Reynaldo H. Verdejo Pinochet 2013-10-10 20:25:29 UTC
Thanks for taking a look ;)

commit 94a3394edffb0e27a44464625b07bebf28991b4b
Author: Reynaldo H. Verdejo Pinochet <>
Date:   Thu Oct 10 08:30:27 2013 -0700

    core: Fix max DEBUG_LEVEL incongruence on 5 vs 9

    In the docs and the autocompletion logic the maximum
    value jumped incongruently between 5 and 9.
Comment 3 Tim-Philipp Müller 2013-10-10 20:32:05 UTC
Please try to put the bug url at the bottom of commit messages where applicable, and set target milestone to the next stable version (or dev version if only pushed to master) that will have the commit. (Otherwise set to none)
Comment 4 Reynaldo H. Verdejo Pinochet 2013-10-10 21:35:33 UTC
Hi Tim. Thanks for your comments.

The lack of #bugno in the commit msg relates to the fact the patch
predates the bug report (I filled it just to get the patch reviewed),
so it felt backwards to mod the msg afterwards. I can do it if it's a
requirement of course (I already do when the bug report predates the fix).
Please confirm and I will make sure to follow suit.

About the milestone I commited to both master and 1.2 so thought 1.2.X
was the correct one.
Comment 5 Sebastian Dröge (slomo) 2013-10-11 08:37:59 UTC
You can rewrite commit messages with "git commit --amend" (if it's the top commit), or "git rebase origin/master --interactive" for example. Also if you use git-bz, it can help you to create bug reports or attach commits to bug reports automatically (and will add the bug url to the commit messages). Makes everything much easier :)

The target milestone should always be the next release that this fix will be part of, with stable releases taking preferences over unstable ones. So stuff that is backported to 1.2 now would get 1.2.1, stuff that only is in master will get 1.3.1. I don't know what the 1.2.X or 1.3.X milestone is good for :)