After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709752 - Don't require neon library for Subversion 1.8
Don't require neon library for Subversion 1.8
Status: RESOLVED FIXED
Product: anjuta
Classification: Applications
Component: unknown
3.10.x
Other OpenBSD
: Normal normal
: ---
Assigned To: Anjuta maintainers
Anjuta maintainers
Depends on:
Blocks:
 
 
Reported: 2013-10-09 16:25 UTC by Stefan Sperling
Modified: 2013-10-10 20:52 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
Patch that implements my suggestion. Tested on OpenBSD. (2.11 KB, patch)
2013-10-09 16:25 UTC, Stefan Sperling
none Details | Review
Patch that implements my suggestion. (3.32 KB, patch)
2013-10-09 16:55 UTC, Stefan Sperling
committed Details | Review

Description Stefan Sperling 2013-10-09 16:25:34 UTC
Created attachment 256835 [details] [review]
Patch that implements my suggestion. Tested on OpenBSD.

Subversion 1.8 dropped support for neon in favour of the serf library:
http://subversion.apache.org/docs/release-notes/1.8.html#neon-deleted

Anjuta's configure script currently requires neon for linking with Subversion. This is an unreasonable requirement.

Subversion 1.5 , 1.6, and 1.7 can be compiled without HTTP client support, or with neon, or serf, or both neon and serf. Subversion 1.8 either uses serf or doesn't support HTTP.

I'd suggest to detect neon and/or serf with pkg-config and include any detected compiler and linker flags in the build. If neon or serf is present on the system it is reasonable to assume that Subversion is using either or both of them. Subversion is rarely compiled without HTTP client functionality.
so with this approach Anjuta should be able to link to virtually any Subversion installation.
Comment 1 Stefan Sperling 2013-10-09 16:27:50 UTC
By the way, if Subversion offered a pkg-config file for itself, none of this would be necessary. So I'll try to make pkg-config support happen for Subversion 1.9.
Comment 2 Stefan Sperling 2013-10-09 16:48:13 UTC
I've filed an issue for pkg-config support in Subversion 1.9: http://subversion.tigris.org/issues/show_bug.cgi?id=4435
Comment 3 Stefan Sperling 2013-10-09 16:55:08 UTC
Created attachment 256838 [details] [review]
Patch that implements my suggestion.

I've attached an improved version of my patch which allows packagers to disable neon and/or serf depedencies via configure script arguments if needed.

This is required for a reproducible build with OpenBSD's ports tree, where anjuta shouldn't add a hidden dependency on neon if the neon package is installed but not used by Subversion.
Comment 4 Sébastien Granjoux 2013-10-10 20:52:16 UTC
Review of attachment 256838 [details] [review]:

Thank you very much for your patch. I have committed it. Indeed it will be even better if subversion can provide pkg-config files.