After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709691 - Replace GDataMock for uhttpmock
Replace GDataMock for uhttpmock
Status: RESOLVED FIXED
Product: libgdata
Classification: Platform
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: libgdata-maint
libgdata-maint
Depends on:
Blocks:
 
 
Reported: 2013-10-08 23:40 UTC by Fabiano Fidêncio
Modified: 2013-10-28 13:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
tests: Replace GDataMock for uhttpmock (156.96 KB, patch)
2013-10-08 23:41 UTC, Fabiano Fidêncio
committed Details | Review

Description Fabiano Fidêncio 2013-10-08 23:40:56 UTC
Although I still don't have the same result in "make check" (what can be       
caused by my last system upgrade), I would like to keep this work in a         
separate branch and have it ready to integrate with master as soon we as have  
uhttpmock being shipped by distros.
Comment 1 Fabiano Fidêncio 2013-10-08 23:41:24 UTC
Created attachment 256775 [details] [review]
tests: Replace GDataMock for uhttpmock
Comment 2 Philip Withnall 2013-10-27 23:46:31 UTC
Review of attachment 256775 [details] [review]:

Looks good to me, and works as well as the existing tests (as long as I use a recent enough version of libsoup). Thanks for the patch, and sorry it took so long to review!

Merged to master.

commit 88e22b33cabf5555f3865dd38598f145fbd89d8b
Author: Fabiano Fidêncio <fidencio@redhat.com>
Date:   Sun Sep 15 22:00:11 2013 +0200

    tests: Replace GDataMock for uhttpmock
    
    https://bugzilla.gnome.org/show_bug.cgi?id=709691

 configure.ac                          |    5 +
 gdata/tests/Makefile.am               |    8 +-
 gdata/tests/calendar.c                |   70 +-
 gdata/tests/client-login-authorizer.c |   32 +-
 gdata/tests/common.c                  |   50 +-
 gdata/tests/common.h                  |   20 +-
 gdata/tests/contacts.c                |   82 +-
 gdata/tests/documents.c               |  102 +--
 gdata/tests/mock-resolver.c           |  336 ---------
 gdata/tests/mock-resolver.h           |   58 --
 gdata/tests/mock-server.c             | 1647 -----------------------------------------
 gdata/tests/mock-server.h             |   92 ---
 gdata/tests/oauth1-authorizer.c       |   44 +-
 gdata/tests/picasaweb.c               |   82 +-
 gdata/tests/youtube.c                 |  120 +--
 15 files changed, 313 insertions(+), 2435 deletions(-)
Comment 3 Colin Walters 2013-10-28 12:58:40 UTC
Hi, I'm unable to reach gitorious.org at the moment, so I had to "tag" libgdata in Continuous for now:

https://git.gnome.org/browse/gnome-continuous/commit/?id=d2959751c7a02a60a93ae0070814c5732fdeda4c

Is there a mirror somewhere?  Or why not have this library in GNOME infrastructure since it seems pretty related?
Comment 4 Colin Walters 2013-10-28 13:17:17 UTC
Nevermind, was pilot error.  Fixed and builds again.