GNOME Bugzilla – Bug 709674
Ignore non-phonebook-enabled modems in ofono backend
Last modified: 2013-10-14 17:15:46 UTC
The ofono backend currently doesn’t check whether a modem supports the org.ofono.Phonebook interface before trying to create a persona store for the it. Persona stores can’t work without a phone book to back them. Patch coming to check whether the phone book interface is supported before creating a persona store.
Created attachment 256753 [details] [review] ofono: Work around a Vala bug causing a double-free when adding a modem Work around Vala bug #709665: https://bugzilla.gnome.org/show_bug.cgi?id=709665 which allowed an assignment of a string*[] value to a string[] variable. string*[] values need the container freeing, but not the members of the array. However, since the variable was a string[], Vala generated C code to free both the container and the members, resulting in a double-free of each member.
Review of attachment 256753 [details] [review]: Looks good
Comment on attachment 256753 [details] [review] ofono: Work around a Vala bug causing a double-free when adding a modem commit 6f332795b9162fb7c8393a96848c8ff5ab35340b Author: Philip Withnall <philip.withnall@collabora.co.uk> Date: Tue Oct 8 19:51:30 2013 +0100 Bug 709674 — Ignore non-phonebook-enabled modems in ofono backend Ignore ofono modems which don’t support the org.ofono.Phonebook interface, which is needed for accessing contacts stored on the SIM. Closes: https://bugzilla.gnome.org/show_bug.cgi?id=709674 NEWS | 1 + backends/ofono/ofono-backend.vala | 39 ++++++++++++++++++++++++++++++++++----- 2 files changed, 35 insertions(+), 5 deletions(-)