After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709621 - gdkevents.h: Mention _get_source_device()
gdkevents.h: Mention _get_source_device()
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: X11
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-10-08 09:45 UTC by Bastien Nocera
Modified: 2013-10-16 01:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gdkevents.h: Mention _get_source_device() (3.43 KB, patch)
2013-10-08 09:45 UTC, Bastien Nocera 		reviewed Details | Review
gdkevents.h: Mention _get_source_device() (3.31 KB, patch)
2013-10-09 15:01 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2013-10-08 09:45:13 UTC 
.
Comment 1 Bastien Nocera 2013-10-08 09:45:16 UTC 
Created attachment 256707 [details] [review]
gdkevents.h: Mention _get_source_device()

It's too easy getting bitten by the ->device red herring, thinking
that it's the original input device the event originated from.
Comment 2 Matthias Clasen 2013-10-08 22:16:43 UTC 
Review of attachment 256707 [details] [review]:

The wording strikes me as a little unfortunate, due to the repetition of 'original'. Can we just change it to say something like 

@device: the master device that the event originated from. Use gdk_event_get_source_device() to get the slave device.
Comment 3 Bastien Nocera 2013-10-09 15:01:58 UTC 
Created attachment 256820 [details] [review]
gdkevents.h: Mention _get_source_device()

It's too easy getting bitten by the ->device red herring, thinking
that it's the original input device the event originated from.
Comment 4 Matthias Clasen 2013-10-16 01:32:07 UTC 
Attachment 256820 [details] pushed as c4c11a1 - gdkevents.h: Mention _get_source_device()