After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709584 - U+258F too wide, U+2595 invisible
U+258F too wide, U+2595 invisible
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
0.34.x
Other Linux
: Normal trivial
: ---
Assigned To: VTE Maintainers
VTE Maintainers
[fixed-0-36][needed-next][commit:b3c4...
Depends on:
Blocks:
 
 
Reported: 2013-10-07 17:35 UTC by Egmont Koblinger
Modified: 2014-04-06 18:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
text file for testing (137 bytes, text/plain)
2013-10-07 18:24 UTC, Egmont Koblinger 		  Details
Fix (2.71 KB, patch)
2013-10-07 18:36 UTC, Egmont Koblinger 		none Details | Review
text file for testing, v2 (120 bytes, text/plain)
2013-10-07 18:53 UTC, Egmont Koblinger 		  Details
Fix v2 (2.96 KB, patch)
2013-10-07 19:33 UTC, Egmont Koblinger 		none Details | Review
Fix v3 (4.01 KB, patch)
2013-10-08 21:41 UTC, Egmont Koblinger 		committed Details | Review

Description Egmont Koblinger 2013-10-07 17:35:55 UTC 
With 6x13 pixel font (Monospace 8), the character U+258F (left one eighth block) is 2px wide, wider than U+2581/U+2594 (upper/lower one eighth block).

Furthermore, U+2595 (right one eighth block) is invisible.
Comment 1 Egmont Koblinger 2013-10-07 18:24:46 UTC 
Created attachment 256655 [details]
text file for testing
Comment 2 Egmont Koblinger 2013-10-07 18:36:09 UTC 
Created attachment 256658 [details] [review]
Fix
Comment 3 Egmont Koblinger 2013-10-07 18:53:03 UTC 
Created attachment 256662 [details]
text file for testing, v2

Improved testing file.

Unfortunately it reveals that the top/right 1/8 characters don't always perfectly align with the bottom/left 7/8 ones.
Comment 4 Egmont Koblinger 2013-10-07 19:33:41 UTC 
Created attachment 256667 [details] [review]
Fix v2

This patch also addresses the previous issue.
Comment 5 Egmont Koblinger 2013-10-08 21:41:15 UTC 
Created attachment 256766 [details] [review]
Fix v3

Created an even better test case (containing every character in 2580-259f in various ways of being adjacent to each other), made it part of the patch. Added a reference to this file in a comment.

The actual code is the same as the previous version.
Comment 6 Christian Persch 2013-10-19 21:05:00 UTC 
I changed the code a bit so as to not put the arithmetic inside the MAX, and committed to 0-36. Thanks for the patch!