After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709571 - implement shell_global_reexec_self on OpenBSD
implement shell_global_reexec_self on OpenBSD
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.10.x
Other OpenBSD
: Normal minor
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-10-07 14:21 UTC by Antoine Jacoutot
Modified: 2013-10-31 10:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
implement shell_global_reexec_self on OpenBSD (1.65 KB, patch)
2013-10-07 14:21 UTC, Antoine Jacoutot
accepted-commit_now Details | Review

Description Antoine Jacoutot 2013-10-07 14:21:44 UTC
Created attachment 256627 [details] [review]
implement shell_global_reexec_self on OpenBSD

Hi.

This patch allows alt+f2 then 'r' to work on OpenBSD.
I tried to keep the patch it as small as possible. Would it be alright to push?

Thanks.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-10-07 14:24:38 UTC
I'd hate to be in the business of supporting this for various platforms for a silly developer feature. I wonder if it should be in a support library like libgsystem which we can pull in, or in systemd itself.
Comment 2 Antoine Jacoutot 2013-10-07 14:31:57 UTC
Well it's not that a silly feature actually ;-)
Sure it's not like it's a must-have or anything but I've come to use and appreciate it.
Putting it in systemd will render any chance of portability moot...
I do agree factorizing this into a lib would be nice actually, since I've found myself fixing this particular thing several times.
Comment 3 Colin Walters 2013-10-07 17:34:11 UTC
Review of attachment 256627 [details] [review]:

Looks fine to me.  Not really a fan of putting it in libgsystem; were other internal components like g-s-d to want reexec, libgnome-desktop maybe?
Comment 4 Antoine Jacoutot 2013-10-08 08:26:14 UTC
I am all confused now ;-) -- should I go ahead and push this or wait?
Comment 5 Antoine Jacoutot 2013-10-12 14:42:25 UTC
Ok guys I will push this within the next 24h unless there is objection.
Thank you.
Comment 6 Antoine Jacoutot 2013-10-31 10:48:36 UTC
Oops, that was a long 24h ;-)
Anyway it's in now, thanks you Colin (15ff426be8e76af7c038feb3b754fbfde4056e5d).