After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709551 - Add large files support
Add large files support
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: librygel-server
git master
Other Linux
: Normal normal
: ---
Assigned To: rygel-maint
rygel-maint
Depends on:
Blocks:
 
 
Reported: 2013-10-07 09:58 UTC by Jean-Baptiste Dubois
Modified: 2013-10-15 09:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
PATCH [PATCH]: Add large files (> 4GB) streaming support (4.55 KB, patch)
2013-10-07 09:58 UTC, Jean-Baptiste Dubois 		needs-work Details | Review
engine: Add large files (> 4GB) streaming support. (4.40 KB, patch)
2013-10-14 09:11 UTC, Jens Georg 		none Details | Review
engine: Add large files (> 4GB) streaming support. (4.71 KB, patch)
2013-10-14 09:56 UTC, Jens Georg 		committed Details | Review

Description Jean-Baptiste Dubois 2013-10-07 09:58:15 UTC 
Created attachment 256608 [details] [review]
PATCH  [PATCH]: Add large files (> 4GB) streaming support

I would like to submit a patch regarding large files support in rygel media server.
The major part of this patch is done inside rygel-simple-data-source where we try to mmap a large file in the process virtual address space (4GB).
As we can't mmap file > 4GB, this patch replaces mmap with simple read syscall.
Comment 1 Jens Georg 2013-10-10 11:34:23 UTC 
Review of attachment 256608 [details] [review]:

Has some missing spaces before and after (), otherwise looks good.
Comment 2 Jens Georg 2013-10-14 09:11:42 UTC 
Created attachment 257236 [details] [review]
engine: Add large files (> 4GB) streaming support.

Slightly updated version for style and error handling
Comment 3 Jens Georg 2013-10-14 09:56:23 UTC 
Created attachment 257239 [details] [review]
engine: Add large files (> 4GB) streaming support.

Turns out IOError.from_errno is broken, so create the IOError manually as in
the original patch.

https://bugzilla.gnome.org/show_bug.cgi?id=710085
Comment 4 Jens Georg 2013-10-15 09:21:33 UTC 
Attachment 257239 [details] pushed as 4b91541 - engine: Add large files (> 4GB) streaming support.