After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709528 - vp8enc is not removing the _DELTA_UNIT flag from keyframes
vp8enc is not removing the _DELTA_UNIT flag from keyframes
Status: RESOLVED INVALID
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-10-06 20:25 UTC by Reynaldo H. Verdejo Pinochet
Modified: 2013-10-07 15:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed fix for the (likely) wrong comparison in vp8enc (911 bytes, patch)
2013-10-06 20:25 UTC, Reynaldo H. Verdejo Pinochet 		rejected Details | Review

Description Reynaldo H. Verdejo Pinochet 2013-10-06 20:25:44 UTC 
Created attachment 256586 [details] [review]
Proposed fix for the (likely) wrong comparison in vp8enc

While working on a fix for #619374 I noticed that every single
frame from a vp8enc encoded stream had GST_BUFFER_FLAG_DELTA_UNIT
set. My impression is this comes from a wrong comparison in
gstvp8enc but maybe I'm missing something. Patch attached
Comment 1 Sebastian Dröge (slomo) 2013-10-07 09:46:04 UTC 
Comment on attachment 256586 [details] [review]
Proposed fix for the (likely) wrong comparison in vp8enc

Yes, that patch is not right.

The first invisible frame buffer should be a keyframe if the frame is a keyframe. Not all of them.

And if there are no invisible frames for this frame (code below), it should mark the buffer as keyframe if the frame is a keyframe
Comment 2 Reynaldo H. Verdejo Pinochet 2013-10-07 15:37:15 UTC 
Can't reproduce anymore. Seems like it was actually a problem with my
test case (and/or tree). Thanks for the comments Sebastian.