GNOME Bugzilla – Bug 709495
Remove EggSMClient
Last modified: 2014-11-07 02:22:43 UTC
Created attachment 256556 [details] [review] Remove EggSMClient Patch for removing EggSMClient. Doing this: 1) We are not using deprecated gdk_threads_[enter/leave] functions. 2) We are using less gdk_x11_* functions. If I understand correctly than if we want make gnome-panel work with wayland in future than we should get ride of gdk_x11 function using. Currently I did not remove eggdesktopfile, but I think it is safe to remove it too. Seems we are using it only to set application name and icon. I think we should not need that all code for this simple task. Setting it to default name and default icon should be ok. This patch also fix typo in gnome-panel/libpanel-applet-private/Makefile.am
Created attachment 257027 [details] [review] Remove EggSMClient Fixed white space errors in this patch.
Review of attachment 257027 [details] [review]: What is the reason that you moved eggdesktopfile.[ch] out of the libegg dir ? I'd like to revert that, as it doesn't buy us anything. (Making libegg smaller is ok, as it's our own private library we're building.) Also, as I think I wrote before, I'd like to keep panel-session.[ch] around, and make it a no-op for now.
(In reply to comment #2) > Review of attachment 257027 [details] [review]: > > What is the reason that you moved eggdesktopfile.[ch] out of the libegg dir ? > I'd like to revert that, as it doesn't buy us anything. (Making libegg smaller > is ok, as it's our own private library we're building.) If you want you can revert it or just use patch which removes both things. Should I add that patch to this bug? > Also, as I think I wrote before, I'd like to keep panel-session.[ch] around, > and make it a no-op for now. Why you want it to keep? If sm client is removed than panel-session is useless.
(In reply to comment #3) > If you want you can revert it or just use patch which removes both things. > Should I add that patch to this bug? Yeah, add it also, I'll review it again in light of the new information. > > Also, as I think I wrote before, I'd like to keep panel-session.[ch] around, > > and make it a no-op for now. > > Why you want it to keep? If sm client is removed than panel-session is useless. Because there have been different ideas toyed with for the gnome destop what to do about session managment in the future, and when something definite comes along, git will handle forwards- / backwards- / sidewards-merging much better if the file never actually disappeared. It's simple enough. Also, and I know I'm trying to walk an impossibly fine line here, for the moment we're trying to keep compatibility with the larger mate-desktop, and I'm not sure if they've gotten around to dropping session managment yet.
Created attachment 257994 [details] [review] Remove libegg
(In reply to comment #4) > (In reply to comment #3) > > If you want you can revert it or just use patch which removes both things. > > Should I add that patch to this bug? > Yeah, add it also, I'll review it again in light of the new information. Added. :) > > > Also, as I think I wrote before, I'd like to keep panel-session.[ch] around, > > > and make it a no-op for now. > > > > Why you want it to keep? If sm client is removed than panel-session is useless. > > Because there have been different ideas toyed with for the gnome destop what to > do about session managment in the future, and when something definite comes > along, git will handle forwards- / backwards- / sidewards-merging much better > if the file never actually disappeared. It's simple enough. So you want keep empty files? I don't like that, but ok. Please edit patch yourself to make necessary changes to keep session files. > Also, and I know I'm trying to walk an impossibly fine line here, for the > moment we're trying to keep compatibility with the larger mate-desktop, and I'm > not sure if they've gotten around to dropping session managment yet. I disagree on this too. We should focus on bug fixing, fixing deprecated things and making it better not trying to keep compatibility with MATE. I have found on more thing that sooner or later we will have deal with. gtk+ 3.10 have deprecated image menu items. What we will do about it? I wanted to move internal menu bar to menu-bar applet with adding properties dialog to applet. So user can easy choose to show/hide icons in menu bar items. set icon size. Configure to Show only label or icon + label or only icon ([start-here icon][Applications], [folder icon] [Places]). And to allow user to choose how many bookmarks he wants to see before bookmarks are created as submenu. Now I don't know what to do.
So the patch is not (only) about removing libegg, but also about removing session management? Would be very nice to mention in the commit message.
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.