GNOME Bugzilla – Bug 709471
[regression] Need to reimplement undo/redo everywhere
Last modified: 2014-05-26 17:36:04 UTC
We need to make sure that it works for Timeline operations: - Splitting - (un)grouping - Deleting clips (or portions of clips) - Inserting clips - Moving, trimming, ripple/roll editing Adding/removing effects Changing an effect's property (including keyframes?) etc. Ideally all of this should be proven/tested with dogtail tests, or some other internal tests, or big fat warnings spitted by loggable whenever undoable detects something wrong...
Just as a reference, it is mostly done at: https://github.com/thiblahute/Pitivi/tree/undo
And for the record, here's what Mathieu had to say last month about saving this into the file formats: Using and adapting the newly disclosed scenario API from Thibault, we want to serialize undo / redo actions as a scenario. This serves many purposes: - It will make undo / redo persistent (you can close pitivi and get back the history) - It will make debugging easier and independent from pitivi, as you shall be able to ges-launch a scenario. - Eventually we should be able to "revert to last saved version".
(In reply to comment #2) > Using and adapting the newly disclosed scenario API from Thibault, we want to > serialize undo / redo actions as a scenario. This serves many purposes: > > - It will make undo / redo persistent > (you can close pitivi and get back the history) I am not sure at all about that, the goal is to make it easier to reproduce bugs, and avoid to need the whole pitivi stack to reproduce making debugging easier. I think making undo redo persistant is another problem, and is out of the scope of the scenarios.
*** Bug 721974 has been marked as a duplicate of this bug. ***
Created attachment 269121 [details] [review] pitivi: Reimplement undo redo This is a rebased version of my patch, I think it still need some work but a first review would be good to have.
Created attachment 273442 [details] [review] fixes the reported issue
Reviewed, rebased on python3 + headerbar, and fixed issues with EffectAdded / EffectRemoved, good to go for me, Thibault was there anything that was wrong with the patch apart from the EffectAdded / Removed issues ?
(In reply to comment #7) > Reviewed, rebased on python3 + headerbar, and fixed issues with EffectAdded / > EffectRemoved, good to go for me, Thibault was there anything that was wrong > with the patch apart from the EffectAdded / Removed issues ? We will need some more testing fixing, but I think it makes sense to push it.
OK this is no FIXED! Closing.