GNOME Bugzilla – Bug 709439
Polari doesn't handle well uppercase in nicknames
Last modified: 2021-06-10 11:05:26 UTC
I know Company's nickname is spelled with an uppercase "C", as evidenced by people addressing him directly, but when he says something, Polari shows his nickname as "company", i.e with a lowercase "c". Also, he doesn't appear in the user list. Finally, fmuellner says he tried changing his nickname to FMuellner, but nothing happened.
Created attachment 256552 [details] [review] chatroomManager: Request ALIAS feature for contacts Otherwise TpContact:alias falls back to TpContact:identifier, which may differ in case.
Created attachment 256553 [details] [review] userList: Use case-insensitive sort function Now that we finally display nicks using their actual case (cough, cough), we need to adjust our sort function to not be case-sensitive.
Attachment 256552 [details] pushed as 0c3273b - chatroomManager: Request ALIAS feature for contacts Attachment 256553 [details] pushed as ad454ed - userList: Use case-insensitive sort function (In reply to comment #0) > I know Company's nickname is spelled with an uppercase "C", as evidenced by > people addressing him directly, but when he says something, Polari shows his > nickname as "company", i.e with a lowercase "c". I'm still seeing this occasionally with the first patch applied, so leaving the bug open. > Also, he doesn't appear in the user list. Mmmh, I've never seen that (e.g. users with known uppercase nicks have always shown up for me, though with wrong case of course) > Finally, fmuellner says he tried changing his nickname to FMuellner, but > nothing happened. This still doesn't work. Without looking into it much, I suspect a tp/tp-idle issue here ...
Created attachment 256555 [details] [review] userList: Fix sorting by the user aliases Your last commit completely broke the sorting. I think it should have been row1._member.alias, not row1.user.alias. Attached patch fixes sorting for me.
Review of attachment 256555 [details] [review]: Ugh yes, sorry - bad rebase.
Pushed. I'm not sure how to mark the patch as « committed », though.
Comment on attachment 256555 [details] [review] userList: Fix sorting by the user aliases You can either use git-bz to push/edit, or adjust the status under details.
bug from telepathy TP_CHANNEL_GROUP_CHANGE_REASON_RENAMED signal not emitted when we only change uppercase letters. https://bugs.freedesktop.org/show_bug.cgi?id=71787
That's not a bug: if the unique identifier (the lower-case form of the nick) didn't change, then from Telepathy's point of view you weren't renamed (e.g. all the messages that would have reached you will still reach you). Watch for TpContact::notify::alias to see case-only changes.
(In reply to comment #9) > Watch for TpContact::notify::alias to see case-only changes. For every user in every room? That's a bit sad ...
Or connect to AliasesChanged with tp_cli_connection_interface_aliasing_connect_to_aliases_changed() if you want the underlying D-Bus signal, which sees every contact on the TpConnection. That's how TpContact works behind the scenes (the TpConnection does the signal-connecting and dispatches to its contacts, to avoid having n D-Bus signal connections). As usual, IRC is the odd one out among the protocols we support: the rest normally have much smaller conversations, and their contacts' unique identifiers don't resemble their aliases.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version of Polari, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new ticket at https://gitlab.gnome.org/GNOME/polari/-/issues/ Thank you for your understanding and your help.