After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709419 - nm-applet should be still autostarted in fallback/flashback sessions
nm-applet should be still autostarted in fallback/flashback sessions
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: nm-applet
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
: 709679 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-10-04 10:38 UTC by Dmitry Shachnev
Modified: 2013-10-28 15:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Make sure applet is still started in gnome-flashback session (797 bytes, patch)
2013-10-04 10:39 UTC, Dmitry Shachnev 		none Details | Review
Make sure applet is still started in gnome-flashback session (863 bytes, patch)
2013-10-04 10:58 UTC, Dmitry Shachnev 		none Details | Review
applet: redo the gnome-shell interaction code (7.45 KB, patch)
2013-10-10 15:23 UTC, Dan Winship 		committed Details | Review

Description Dmitry Shachnev 2013-10-04 10:38:09 UTC 
The GNOME Flashback session (https://wiki.gnome.org/GnomeFlashback) is the primary user of nm-applet, so it would make sense to autostart it there.
Comment 1 Dmitry Shachnev 2013-10-04 10:39:39 UTC 
Created attachment 256458 [details] [review]
Make sure applet is still started in gnome-flashback session
Comment 2 Dmitry Shachnev 2013-10-04 10:58:25 UTC 
Created attachment 256460 [details] [review]
Make sure applet is still started in gnome-flashback session

Sorry, forgot about X-GNOME-Autostart-enabled, this is updated version.
Comment 3 Dan Winship 2013-10-04 13:06:59 UTC 
I don't think that's right; you want the default to be off, and only turn it on in gnome-flashback, rather than the other way around. (In case people/distros define additional GNOME3 sessions.)
Comment 4 Pavel Simerda 2013-10-04 13:17:47 UTC 
(In reply to comment #3)
> I don't think that's right; you want the default to be off, and only turn it on
> in gnome-flashback, rather than the other way around. (In case people/distros
> define additional GNOME3 sessions.)

+1
Comment 5 Dmitry Shachnev 2013-10-04 15:11:42 UTC 
Is it possible to define two or more allowed sessions? I.e. in Ubuntu we have "gnome-flashback" and "gnome-flashback-compiz" sessions.
Comment 6 Dan Winship 2013-10-10 13:58:15 UTC 
*** Bug 709679 has been marked as a duplicate of this bug. ***
Comment 7 Dan Winship 2013-10-10 13:59:03 UTC 
(In reply to comment #5)
> Is it possible to define two or more allowed sessions? I.e. in Ubuntu we have
> "gnome-flashback" and "gnome-flashback-compiz" sessions.

I'm not sure. Try it... (or check the gnome-session source code)
Comment 8 Dmitry Shachnev 2013-10-10 14:10:59 UTC 
Looks like gnome-session doesn't support that. But, like Tim mentions in a duplicate bug, it should also be autostarted in sessions like gnome-xmonad, so I don't like the idea of marking it 'if-session gnome-flashback'.

Can we maybe make nm-applet exit if gnome-shell is running (i.e. by checking for its D-Bus interface)?
Comment 9 Dan Winship 2013-10-10 15:23:06 UTC 
Created attachment 256922 [details] [review]
applet: redo the gnome-shell interaction code

Change the shell interaction code so that we only create an
NMSecretAgent if the shell is not running, and we permanently destroy
it if the shell ever starts up.

Revert the change to not run nm-applet under GNOME 3 now, since it
should be safe to do so, and this solves the problem for users who
need the GSM PIN unlock dialog.
Comment 10 Dan Winship 2013-10-10 15:23:28 UTC 
can people test that patch?
Comment 11 Dmitry Shachnev 2013-10-11 05:36:50 UTC 
Thanks for the patch. I will be able to test it only next week, hope it can wait.
Comment 12 Dmitry Shachnev 2013-10-21 17:48:31 UTC 
Review of attachment 256922 [details] [review]:

Sorry for the delay. With this patch nm-applet still starts in gnome-flashback and Unity, so this looks good to me.
Comment 13 yefexe7584 2013-10-24 12:57:26 UTC 
In my experience nm-applet is autostarted but the line 

NotShowIn=KDE;GNOME; 

in /etc/xdg/autostart/nm-applet.desktop needs to be commented for the applet to appear in the system tray.
Comment 14 Dmitry Shachnev 2013-10-24 13:08:58 UTC 
Charles, the patch in question changes that line to allow GNOME.
Comment 15 Jiri Klimes 2013-10-25 10:23:22 UTC 
The patch looks right, but I didn't actually test it. I'll hopefully try later.
Comment 16 Dan Winship 2013-10-28 15:22:48 UTC 
fixed in master, and there will soon be another 0.9.8 release with the
fix as well

Attachment 256922 [details] pushed as e192e83 - applet: redo the gnome-shell interaction code