After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709417 - Use a consistent set of permissions to create the user's config, cache and data directories
Use a consistent set of permissions to create the user's config, cache and da...
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: general
3.10.x
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-10-04 09:44 UTC by Debarshi Ray
Modified: 2013-10-05 10:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use a consistent set of permissions when creating directories (1.80 KB, patch)
2013-10-04 09:46 UTC, Debarshi Ray 		needs-work Details | Review
Use a consistent set of permissions when creating directories (3.79 KB, patch)
2013-10-04 10:12 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2013-10-04 09:44:25 UTC 
We are using a mix of 0700 and 0755 throughout the code to create the user's config, cache and data directories. I think we should be consistent.

I don't know which is more correct, but a quick glance at my own system indicates that 0700 is more prevalent.
Comment 1 Debarshi Ray 2013-10-04 09:46:15 UTC 
Created attachment 256454 [details] [review]
Use a consistent set of permissions when creating directories
Comment 2 Bastien Nocera 2013-10-04 09:49:05 UTC 
Review of attachment 256454 [details] [review]:

I'd rather it was defined in config.h and used as a macro.
Comment 3 Debarshi Ray 2013-10-04 10:12:08 UTC 
Created attachment 256455 [details] [review]
Use a consistent set of permissions when creating directories
Comment 4 Bastien Nocera 2013-10-04 10:16:51 UTC 
Review of attachment 256455 [details] [review]:

Looks good, though USER_DIR_MODE is a bit vague, but I couldn't think of a better term.
Comment 5 Debarshi Ray 2013-10-04 11:30:54 UTC 
Comment on attachment 256455 [details] [review]
Use a consistent set of permissions when creating directories

Thanks for the review.