After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709308 - user-accounts: Add option to open the history dialogue
user-accounts: Add option to open the history dialogue
Status: RESOLVED OBSOLETE
Product: gnome-control-center
Classification: Core
Component: User Accounts
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks: 708846
 
 
Reported: 2013-10-02 19:27 UTC by Bastien Nocera
Modified: 2021-06-09 16:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
user-accounts: Add option to open the history dialogue (4.88 KB, patch)
2013-10-02 19:27 UTC, Bastien Nocera
needs-work Details | Review

Description Bastien Nocera 2013-10-02 19:27:20 UTC
.
Comment 1 Bastien Nocera 2013-10-02 19:27:33 UTC
Created attachment 256317 [details] [review]
user-accounts: Add option to open the history dialogue
Comment 2 Rui Matos 2013-10-03 09:46:07 UTC
Review of attachment 256317 [details] [review]:

::: panels/user-accounts/um-user-panel.c
@@ +1531,3 @@
+                        g_variant_get_child (parameters, 1, "v", &v);
+                        if (g_strcmp0 (g_variant_get_string (v, NULL), "history") == 0) {
+                                if (priv->users_loaded)

There's another condition we must wait for: being mapped. Otherwise, if the ActUserManager instance is already loaded (e.g. because we were already in another panel that loads it) we'll try to show_history() during g_object_new() for this panel but we can't determine our toplevel widget yet and we get a detached modal dialog and a couple of prints:

(gnome-control-center:21361): GLib-GObject-WARNING **: invalid cast from 'CcUserPanel' to 'GtkWindow'

(gnome-control-center:21361): Gtk-CRITICAL **: gtk_window_set_transient_for: assertion 'parent == NULL || GTK_IS_WINDOW (parent)' failed
Comment 3 André Klapper 2021-06-09 16:07:37 UTC
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version, then please follow
  https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines
and create a new bug report at
  https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/

Thank you for your understanding and your help.