After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709284 - There isn't a blue underline in the current tab in the new notebook style
There isn't a blue underline in the current tab in the new notebook style
Status: RESOLVED FIXED
Product: gnome-themes-standard
Classification: Core
Component: Adwaita GTK3 theme
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-themes-standard-maint
gnome-themes-standard-maint
Depends on:
Blocks:
 
 
Reported: 2013-10-02 16:55 UTC by Yosef Or Boczko
Modified: 2013-10-08 18:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot (237.78 KB, image/png)
2013-10-02 16:55 UTC, Yosef Or Boczko
  Details
Fix underline on active tab in Web (1.59 KB, patch)
2013-10-07 15:46 UTC, William Jon McCann
reviewed Details | Review
Fix underline on active tab in Web (1.30 KB, patch)
2013-10-07 19:34 UTC, William Jon McCann
committed Details | Review

Description Yosef Or Boczko 2013-10-02 16:55:54 UTC
Created attachment 256298 [details]
Screenshot

In the new notebook style need to be a blue
underline in the current tab, but I not see
this in Epiphany.

See the screenshot.
Comment 1 William Jon McCann 2013-10-07 15:43:53 UTC
Caused by:
commit f008bff348c22c1c87e45e4b3a5d0758e71b59b3
Author: Lapo Calamandrei <calamandrei@gmail.com>
Date:   Wed Oct 10 19:00:00 2012 +0200

    adwaita gtk3: provisionally add style for ephy scrolled window borders
              removal.
Comment 2 William Jon McCann 2013-10-07 15:46:11 UTC
Created attachment 256637 [details] [review]
Fix underline on active tab in Web

The underline in active tabs is being overridden in Web
by setting the bottom border to zero on the notebook. This was
added in commit f008bff348c22c1c87e45e4b3a5d0758e71b59b3.

I don't think this is needed anymore.
Comment 3 Cosimo Cecchi 2013-10-07 17:27:16 UTC
Review of attachment 256637 [details] [review]:

::: themes/Adwaita/gtk-3.0/gnome-applications.css
@@ -581,3 @@
 /* remove bottom borders from the  main scrolled window when no bars at the bottom of the screen are shown */
-EphyWindow.background EphyNotebook:last-child EphyEmbed.vertical GtkScrolledWindow,
-EphyWindow.background EphyNotebook.notebook:last-child {

I think this is the only line you'd need to remove, as it's the only one that changes the appearance of the notebook itself. Not sure if it will break what the comment above says though.
Comment 4 William Jon McCann 2013-10-07 19:34:02 UTC
Created attachment 256668 [details] [review]
Fix underline on active tab in Web

The underline in active tabs is being overridden in Web
by setting the bottom border to zero on the notebook. This was
added in commit f008bff348c22c1c87e45e4b3a5d0758e71b59b3.

I don't think this is needed anymore.
Comment 5 William Jon McCann 2013-10-08 18:50:01 UTC
Attachment 256668 [details] pushed as e027650 - Fix underline on active tab in Web