After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709279 - The close button in the tabs with the new notebook style is too wide
The close button in the tabs with the new notebook style is too wide
Status: RESOLVED FIXED
Product: gnome-themes-standard
Classification: Core
Component: Adwaita GTK3 theme
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-themes-standard-maint
gnome-themes-standard-maint
Depends on:
Blocks:
 
 
Reported: 2013-10-02 16:04 UTC by Yosef Or Boczko
Modified: 2013-10-04 20:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot (134.76 KB, image/png)
2013-10-02 16:04 UTC, Yosef Or Boczko 		  Details
Don't add a large left padding to tab close buttons (885 bytes, patch)
2013-10-04 20:05 UTC, William Jon McCann 		committed Details | Review

Description Yosef Or Boczko 2013-10-02 16:04:19 UTC 
Created attachment 256291 [details]
Screenshot

I don't know why, but this not happen in epiphany,
although the code to add a close button in each tab
in nautilus and in epiphany is almost the same code.

See the screenshot I attached.
Comment 1 Yosef Or Boczko 2013-10-02 23:12:38 UTC 
I see the same bug also in gnome-builder, so moved to gtk+.
Comment 2 William Jon McCann 2013-10-04 19:25:03 UTC 
I can reproduce the bug in epiphany if I remove the following custom css it uses:

#ephy-tab-close-button {
  -GtkButton-default-border: 0;
  -GtkButton-default-outside-border: 0;
  -GtkButton-inner-border: 0;
  -GtkWidget-focus-padding: 0;
  -GtkWidget-focus-line-width: 0;
  margin: 0;
  padding: 0;
}

padding = 0 seems to be the key.
Comment 3 William Jon McCann 2013-10-04 19:54:17 UTC 
Also see bug 648116.
Comment 4 William Jon McCann 2013-10-04 20:05:05 UTC 
Created attachment 256507 [details] [review]
Don't add a large left padding to tab close buttons

This sneaked in during the tab restyling.
Comment 5 William Jon McCann 2013-10-04 20:06:16 UTC 
Attachment 256507 [details] pushed as 83d7792 - Don't add a large left padding to tab close buttons