After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709271 - Fix memory leaks
Fix memory leaks
Status: RESOLVED FIXED
Product: gnome-desktop
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
Depends on:
Blocks: 709243
 
 
Reported: 2013-10-02 14:38 UTC by Bastien Nocera
Modified: 2013-10-02 15:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gnome-bg: Fix memory leaks when using get_as_slideshow() (1.42 KB, patch)
2013-10-02 14:38 UTC, Bastien Nocera 		committed Details | Review
gnome-bg-slideshow: Fix memory leak of a filename (821 bytes, patch)
2013-10-02 14:38 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2013-10-02 14:38:09 UTC 
.
Comment 1 Bastien Nocera 2013-10-02 14:38:12 UTC 
Created attachment 256281 [details] [review]
gnome-bg: Fix memory leaks when using get_as_slideshow()

get_as_slideshow() returns a reference to the slideshow,
which we need to get rid of when we're not using it anymore.
Comment 2 Bastien Nocera 2013-10-02 14:38:17 UTC 
Created attachment 256282 [details] [review]
gnome-bg-slideshow: Fix memory leak of a filename
Comment 3 Colin Walters 2013-10-02 14:48:50 UTC 
Review of attachment 256281 [details] [review]:

Looks good to me.
Comment 4 Colin Walters 2013-10-02 14:49:29 UTC 
Review of attachment 256282 [details] [review]:

Looks right.
Comment 5 Bastien Nocera 2013-10-02 15:25:53 UTC 
Attachment 256281 [details] pushed as af0f0fb - gnome-bg: Fix memory leaks when using get_as_slideshow()
Attachment 256282 [details] pushed as dfc4eca - gnome-bg-slideshow: Fix memory leak of a filename