GNOME Bugzilla – Bug 709259
Make AppData translatable
Last modified: 2013-10-02 15:44:03 UTC
Created attachment 256257 [details] [review] AppData translatable Patch to make AppData file translatable
Review of attachment 256257 [details] [review]: Hey Daniel, I'm confused at what's wrong currently. gnome-chess.appdata.xml is generated by make, so normally I would not expect it to be distributed. Is there some reason it needs to be? If we use INTLTOOL_XML_NOMERGE_RULE instead of INTLTOOL_XML_RULE, then the translated strings won't get merged into the generated gnome-chess.appdata.xml, so while they're marked for translation, GNOME Software. Also, gnome-chess.appdata.xml.in is not generated by make, so it shouldn't be in CLEANFILES.
(In reply to comment #1) > > If we use INTLTOOL_XML_NOMERGE_RULE instead of INTLTOOL_XML_RULE, then the > translated strings won't get merged into the generated gnome-chess.appdata.xml, > so while they're marked for translation, GNOME Software. Whoops, I meant "GNOME Software won't be able to see them"
Well, i'm not really sure about what Makefile's directive does... I'm just following some commited examples to add support for translatable strings in Appdata files, like this one: https://bug708750.bugzilla-attachments.gnome.org/attachment.cgi?id=255687 For more technical questions about you should ask Hughsie, but I think the patch it's ok. Note that the XML is included in the POTFILES.in one, so strings marked as translatables will be extracted and included in the POT file.
It should already be translatable, so unless you're trying to fix a bug with building the translations, I think this can be closed.
Ok for me... I saw in the wiki page the appdata file for this module had no translations, and I got confused. Sorry for the noise!