GNOME Bugzilla – Bug 709121
Update software updates logic
Last modified: 2013-11-02 04:22:52 UTC
Created attachment 256126 [details] logic diagram Now that we are using offline updates for real, we need to change the way that software updates (and their associated notifications) are scheduled. This includes: Since we are preparing updates before notifying the user about them, it makes sense to remind each day after the updates are downloaded about them being ready, for example (rather than waiting a week between updates, as we do now). The attached diagram shows some ideas for how it could work.
We have the basics covered in 3.10: - no double notifications - security updates get notified without delay Richard said that he wants to avoid more drastic changes to the notification / update downloading logic in 3.10. Moving off the 3.10.1 list
Created attachment 258193 [details] [review] incomplete patch
Created attachment 258201 [details] [review] complete patch
Looks good in general. The only thing I'm concerned about is we would be downloading updates on mobile broadband and potentially costing the user a lot of cash. In PkControl we network status enum that we probably should use.
I didn't notice the code dealing with that in the updates plugin. I'll look again and add it when I get back to this. Thanks for the review !
Created attachment 258392 [details] [review] Download updates This moves more functionality from the gsd updates plugin here: * Notify about successful or unsuccessful offline updates 15 seconds after start. * Monitor for available offline updates and notify about them, once per hour. * Refresh the cache once per day, after 6am. * If important updates are available, or updates have not been installed for at least 7 days, download all available updates. We rely on PackageKit to prepare an offline update when updates have been downloaded. * Avoid mobile networks for cache refresh and downloads.
Review of attachment 258392 [details] [review]: I think i'd rather the PackageKit proxy-setting bits split off into another file; it's logically different functionality from the update monitor. After that, it looks good to push, thanks.
Attachment 258392 [details] pushed as 774a67b - Download updates