After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709112 - upstream query for context
upstream query for context
Status: RESOLVED FIXED
Product: gstreamer-vaapi
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gstreamer-vaapi maintainer(s)
gstreamer-vaapi maintainer(s)
Depends on:
Blocks: 698054
 
 
Reported: 2013-09-30 15:54 UTC by Víctor Manuel Jáquez Leal
Modified: 2013-11-18 13:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
context: query upstream for context (3.93 KB, patch)
2013-10-01 15:16 UTC, Víctor Manuel Jáquez Leal 		none Details | Review

Description Víctor Manuel Jáquez Leal 2013-09-30 15:54:35 UTC 
As Slomo said in bug #703235:

> Also the query should be sent downstream, then upstream, then the 
> need-context message.
> 
> Just took a short look at these patches but this part seems to be missing.
Comment 1 Gwenole Beauchesne 2013-09-30 15:56:25 UTC 
Hi, yes, he also mentioned the step (1) IIRC that is, caching the VA display ourselves and checking against it first. Though, we already do that IMHO, before we call gst_vaapi_video_context_prepare().
Comment 2 Víctor Manuel Jáquez Leal 2013-10-01 15:16:55 UTC 
Created attachment 256194 [details] [review]
context: query upstream for context
Comment 3 Víctor Manuel Jáquez Leal 2013-10-01 15:19:54 UTC 
When I play a video with playbin both vaapidecode and vaapisink create their own display. But if I play a video crafting manually the pipeline, the vaapidecode's display is shared correctly. Slomo?
Comment 4 Gwenole Beauchesne 2013-10-01 16:43:08 UTC 
Applied, thanks.

(In reply to comment #3)
> When I play a video with playbin both vaapidecode and vaapisink create their
> own display. But if I play a video crafting manually the pipeline, the
> vaapidecode's display is shared correctly. Slomo?

This also matches my observations from my initial testing.
Comment 5 Gwenole Beauchesne 2013-11-18 13:04:55 UTC 
commit b56144e9241ae826b5eae7c3a3e7454f75259e59
Author: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
Date:   Tue Oct 1 12:09:44 2013 +0200

    plugins: query upstream element for a GstContext.
    
    Fix gst_vaapi_video_context_prepare() to also query upstream elements
    for a valid GstContext. Improve comments regarding the steps used to
    lookup or build that context, thus conforming to the GstContext API
    recommendations.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=709112
    
    Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>