After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709104 - network: Destroy connection row widget when connection is removed
network: Destroy connection row widget when connection is removed
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Network
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-09-30 14:58 UTC by Rui Matos
Modified: 2013-10-01 13:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
network: Destroy connection row widget when connection is removed (1.93 KB, patch)
2013-09-30 14:58 UTC, Rui Matos 		reviewed Details | Review
network: Destroy connection row widget when connection is removed (1.38 KB, patch)
2013-09-30 15:35 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2013-09-30 14:58:54 UTC 
Fixes the crash reported in
https://bugzilla.redhat.com/show_bug.cgi?id=981947 .
Comment 1 Rui Matos 2013-09-30 14:58:56 UTC 
Created attachment 256094 [details] [review]
network: Destroy connection row widget when connection is removed

Otherwise all sorts of crashes may happen if it's interacted with.
Comment 2 Bastien Nocera 2013-09-30 15:23:12 UTC 
Review of attachment 256094 [details] [review]:

::: panels/network/net-device-wifi.c
@@ +1614,3 @@
+                g_signal_connect (G_OBJECT (connection), "removed",
+                                  G_CALLBACK (connection_removed), row);
+                g_object_weak_ref (G_OBJECT (row), row_finalized, connection);

g_signal_connect_object() ?
Comment 3 Rui Matos 2013-09-30 15:35:58 UTC 
Created attachment 256100 [details] [review]
network: Destroy connection row widget when connection is removed

--

(In reply to comment #2)
> g_signal_connect_object() ?

Of course, duh
Comment 4 Bastien Nocera 2013-09-30 15:40:38 UTC 
Review of attachment 256100 [details] [review]:

++
Comment 5 Rui Matos 2013-10-01 13:11:55 UTC 
Attachment 256100 [details] pushed as 22ff598 - network: Destroy connection row widget when connection is removed