After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709093 - qtdemux: add HEVC support
qtdemux: add HEVC support
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 708921
Blocks:
 
 
Reported: 2013-09-30 13:16 UTC by sreerenj
Modified: 2013-10-02 10:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add hevc support in qtdemux (6.75 KB, patch)
2013-09-30 13:16 UTC, sreerenj 		committed Details | Review

Description sreerenj 2013-09-30 13:16:43 UTC 
Created attachment 256083 [details] [review]
Add hevc support in qtdemux

The attached patch is adding HEVC support in qtdemux.

This has a dependency to patch in https://bugzilla.gnome.org/show_bug.cgi?id=708921
Comment 1 Sebastian Dröge (slomo) 2013-10-01 21:44:16 UTC 
Review of attachment 256083 [details] [review]:

::: gst/isomp4/qtdemux.c
@@ +7505,3 @@
+        {
+          gint len = QT_UINT32 (stsd_data) - 0x66;
+          const guint8 *hevc_data = stsd_data + 0x66;

You should check if there is actually enough data available here, and also below in several places
Comment 2 sreerenj 2013-10-02 09:39:57 UTC 
(In reply to comment #1)
> Review of attachment 256083 [details] [review]:
> 
> ::: gst/isomp4/qtdemux.c
> @@ +7505,3 @@
> +        {
> +          gint len = QT_UINT32 (stsd_data) - 0x66;
> +          const guint8 *hevc_data = stsd_data + 0x66;
> 
> You should check if there is actually enough data available here, and also
> below in several places

But the control will reach there if and only if there are enough data. Similar to that of avc1... isn't it?
Comment 3 Sebastian Dröge (slomo) 2013-10-02 09:54:02 UTC 
Yes, you're right. It's a bit convoluted but indeed the checks are there
Comment 4 Sebastian Dröge (slomo) 2013-10-02 09:55:00 UTC 
commit e779b6587b9969808030d706a5e834a38af025eb
Author: Sreerenj Balachandran <sreerenj.balachandran@intel.com>
Date:   Mon Sep 30 12:31:42 2013 +0300

    qtdemux: Add HEVC support
    
    https://bugzilla.gnome.org/show_bug.cgi?id=709093